From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gonglei <arei.gonglei@huawei.com>
Cc: linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org,
linux-crypto@vger.kernel.org, luonengjun@huawei.com,
stefanha@redhat.com, weidong.huang@huawei.com,
wu.wubin@huawei.com, xin.zeng@intel.com,
claudio.fontana@huawei.com, herbert@gondor.apana.org.au,
pasic@linux.vnet.ibm.com, davem@davemloft.net,
jianjay.zhou@huawei.com, hanweidong@huawei.com,
arei.gonglei@hotmail.com, cornelia.huck@de.ibm.com,
xuquan8@huawei.com, longpeng2@huawei.com,
salvatore.benedetto@intel.com
Subject: Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family
Date: Sun, 27 Nov 2016 05:32:53 +0200 [thread overview]
Message-ID: <20161127052802-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1479802223-121104-2-git-send-email-arei.gonglei@huawei.com>
On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote:
> Virtio modern devices are always little edian, let's introduce
> the LE functions for read/write configuration space for
> virtio modern devices, which avoid complaint by Sparse when
> we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> include/linux/virtio_config.h | 45 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> index 26c155b..de05707 100644
> --- a/include/linux/virtio_config.h
> +++ b/include/linux/virtio_config.h
> @@ -414,4 +414,49 @@ static inline void virtio_cwrite64(struct virtio_device *vdev,
> _r; \
> })
>
> +static inline __le16 virtio_cread16_le(struct virtio_device *vdev,
> + unsigned int offset)
> +{
> + __le16 ret;
> +
> + vdev->config->get(vdev, offset, &ret, sizeof(ret));
> + return ret;
> +}
> +
> +static inline void virtio_cwrite16_le(struct virtio_device *vdev,
> + unsigned int offset, __le16 val)
> +{
> + vdev->config->set(vdev, offset, &val, sizeof(val));
> +}
> +
> +static inline __le32 virtio_cread32_le(struct virtio_device *vdev,
> + unsigned int offset)
> +{
> + __le32 ret;
> +
> + vdev->config->get(vdev, offset, &ret, sizeof(ret));
> + return ret;
> +}
> +
> +static inline void virtio_cwrite32_le(struct virtio_device *vdev,
> + unsigned int offset, __le32 val)
> +{
> + vdev->config->set(vdev, offset, &val, sizeof(val));
> +}
> +
> +static inline __le64 virtio_cread64_le(struct virtio_device *vdev,
> + unsigned int offset)
> +{
> + __le64 ret;
> +
> + __virtio_cread_many(vdev, offset, &ret, 1, sizeof(ret));
> + return ret;
> +}
> +
> +static inline void virtio_cwrite64_le(struct virtio_device *vdev,
> + unsigned int offset, __le64 val)
> +{
> + vdev->config->set(vdev, offset, &val, sizeof(val));
> +}
> +
> #endif /* _LINUX_VIRTIO_CONFIG_H */
Could you please better explain what is the issue you are facing?
virtio_cwrite/virtio_cread all accept and return native types.
If you want it in LE format, swap it!
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2016-11-27 3:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 8:10 [PATCH v2 0/2] virtio-crypto: add Linux driver Gonglei
2016-11-22 8:10 ` [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family Gonglei
2016-11-27 3:32 ` Michael S. Tsirkin [this message]
2016-11-28 1:56 ` [virtio-dev] " Gonglei (Arei)
2016-11-28 2:34 ` Michael S. Tsirkin
2016-11-28 2:53 ` Gonglei (Arei)
2016-11-28 2:54 ` Michael S. Tsirkin
2016-11-28 2:57 ` Gonglei (Arei)
2016-11-22 8:10 ` [PATCH v2 2/2] crypto: add virtio-crypto driver Gonglei
2016-11-27 3:27 ` Michael S. Tsirkin
2016-11-28 4:47 ` [virtio-dev] " Gonglei (Arei)
2016-11-28 5:09 ` Michael S. Tsirkin
2016-11-28 5:38 ` Gonglei (Arei)
2016-11-26 9:38 ` [PATCH v2 0/2] virtio-crypto: add Linux driver Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161127052802-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arei.gonglei@hotmail.com \
--cc=arei.gonglei@huawei.com \
--cc=claudio.fontana@huawei.com \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=hanweidong@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=jianjay.zhou@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=luonengjun@huawei.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=salvatore.benedetto@intel.com \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=weidong.huang@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xin.zeng@intel.com \
--cc=xuquan8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).