From: Jessica Yu <jeyu@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
Andreas Ziegler <andreas.ziegler@fau.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: module: extend 'rodata=off' boot cmdline parameter to module mappings
Date: Mon, 28 Nov 2016 14:50:55 -0500 [thread overview]
Message-ID: <20161128195055.GC24161@packer-debian-8-amd64.digitalocean.com> (raw)
In-Reply-To: <20161128091830.GB23034@linaro.org>
+++ AKASHI Takahiro [28/11/16 18:18 +0900]:
>On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
>> Hi Akashi,
>>
>> your patch "module: extend 'rodata=off' boot cmdline parameter to module
>> mappings" showed up in linux-next today, and I noticed a small error in it.
>>
>> The first modified #ifdef is fine, the second one, however, has a spelling
>> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
>> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).
>
>Thank you for pointing this out.
>(I didn't notice it because DEBUG_RODATA is always on on arm64.)
>
>Rusty, Jessica, should I submit v4 to correct it?
Andreas, Akashi -
The typo has been fixed with Arnd's patch:
http://lkml.kernel.org/r/20161128145931.3350661-1-arnd@arndb.de
Thanks for finding the issue!
Jessica
next prev parent reply other threads:[~2016-11-28 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 7:59 [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings Andreas Ziegler
2016-11-28 9:18 ` AKASHI Takahiro
2016-11-28 19:50 ` Jessica Yu [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-14 6:15 AKASHI Takahiro
2016-11-25 5:48 ` Jessica Yu
2016-11-28 0:00 ` Rusty Russell
2016-10-21 1:13 [PATCH v2] " AKASHI Takahiro
2016-11-13 3:04 ` Jessica Yu
2016-11-14 6:12 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128195055.GC24161@packer-debian-8-amd64.digitalocean.com \
--to=jeyu@redhat.com \
--cc=andreas.ziegler@fau.de \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).