linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: Chris Mason <clm@fb.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode)
Date: Mon, 28 Nov 2016 12:12:11 -0800	[thread overview]
Message-ID: <20161128201211.GB5005@localhost.localdomain> (raw)
In-Reply-To: <20161126134638.GA79987@clm-mbp.masoncoding.com>

On Sat, Nov 26, 2016 at 08:46:38AM -0500, Chris Mason wrote:
> On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote:
> > FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+
> 
> Filipe reworked the code to avoid taking the same lock twice.  As far as I
> can tell, this just needs some annotation.

Besides this log_mutex, we have another false lockdep warning around
block_group_cache->data_rwsem, we can use down_read_nested() to get rid
of it.

Thanks,

-liubo

  reply	other threads:[~2016-11-28 20:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  9:03 btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode) Christian Borntraeger
2016-11-26 13:46 ` Chris Mason
2016-11-28 20:12   ` Liu Bo [this message]
2017-01-24  9:01   ` [PATCH 0/1] btrfs lockdep annotation Christian Borntraeger
2017-01-24  9:01     ` [PATCH 2/2] btrfs: add lockdep annotation for btrfs_log_inode Christian Borntraeger
2017-01-24 10:22     ` [PATCH 0/1] btrfs lockdep annotation Filipe Manana
2017-01-24 11:27       ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128201211.GB5005@localhost.localdomain \
    --to=bo.li.liu@oracle.com \
    --cc=borntraeger@de.ibm.com \
    --cc=clm@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).