From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755099AbcK1UyI (ORCPT ); Mon, 28 Nov 2016 15:54:08 -0500 Received: from mail-yb0-f195.google.com ([209.85.213.195]:34012 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcK1UyA (ORCPT ); Mon, 28 Nov 2016 15:54:00 -0500 Date: Mon, 28 Nov 2016 15:53:58 -0500 From: Tejun Heo To: Michal Hocko Cc: Zefan Li , Arnd Bergmann , Kirtika Ruchandani , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable Message-ID: <20161128205358.GA7363@htj.duckdns.org> References: <1480049712-17224-1-git-send-email-kirtika@chromium.org> <5837D01C.1070803@huawei.com> <4410043.lxDXIbV3iK@wuerfel> <5838DA80.6040208@huawei.com> <20161128073709.GA14835@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161128073709.GA14835@dhcp22.suse.cz> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Nov 28, 2016 at 08:37:09AM +0100, Michal Hocko wrote: > I would disagree here. Randomly picking up fixes just because they are > Fixing some commit is just too dangerous for the stable trees. Fixes tag > should tell what was the culprit of the issue fixed by the patch, > nothing more and nothing less. Logically, I agree but then the only time I used the Fixes tag is when I was tagging patches for stable and I can imagine people grepping for the tag to backport. Also, given that the offending commit is already referenced in the description, the tag doesn't make much difference to human beings. I don't think it's a big deal either way but am more inclined to follow Li's suggestion here given that he is maintaining stable trees. Thanks. -- tejun