From: Rob Herring <robh@kernel.org>
To: Ryan Lee <RyanS.Lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com,
perex@perex.cz, tiwai@suse.com, arnd@arndb.de,
michael@amarulasolutions.com, oder_chiou@realtek.com,
yesanishhere@gmail.com, jacob@teenage.engineering,
Damien.Horsley@imgtec.com, bardliao@realtek.com,
kuninori.morimoto.gx@renesas.com, petr@barix.com,
lars@metafoo.de, nh6z@nh6z.net, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA SoC MAX98927 driver - Initial release
Date: Mon, 28 Nov 2016 16:01:53 -0600 [thread overview]
Message-ID: <20161128220153.7ccbt4p3wy2fomis@rob-hp-laptop> (raw)
In-Reply-To: <1479877026-5172-1-git-send-email-RyanS.Lee@maximintegrated.com>
On Wed, Nov 23, 2016 at 01:57:06PM +0900, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
> .../devicetree/bindings/sound/max98927.txt | 32 +
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/max98927.c | 954 +++++++++++++++
> sound/soc/codecs/max98927.h | 1253 ++++++++++++++++++++
> 5 files changed, 2246 insertions(+)
> create mode 100755 Documentation/devicetree/bindings/sound/max98927.txt
> mode change 100644 => 100755 sound/soc/codecs/Kconfig
> mode change 100644 => 100755 sound/soc/codecs/Makefile
> create mode 100755 sound/soc/codecs/max98927.c
> create mode 100755 sound/soc/codecs/max98927.h
>
> diff --git a/Documentation/devicetree/bindings/sound/max98927.txt b/Documentation/devicetree/bindings/sound/max98927.txt
> new file mode 100755
> index 0000000..ddcd332
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/max98927.txt
> @@ -0,0 +1,32 @@
> +max98927 audio CODEC
> +
> +This device supports I2C.
> +
> +Required properties:
> +
> + - compatible : "maxim,max98927"
> +
> + - vmon-slot-no : slot number used to send voltage information
> + or in inteleave mode this will be used as
s/inteleave/interleave/
What is the range of values?
> + interleave slot.
> +
> + - imon-slot-no : slot number used to send current information
Range?
> +
> + - interleave-mode : When using two MAX98927 in a system it is
These all need vendor prefix.
> + possible to create ADC data that that will
> + overflow the frame size. Digital Audio Interleave
> + mode provides a means to output VMON and IMON data
> + from two devices on a single DOUT line when running
> + smaller frames sizes such as 32 BCLKS per LRCLK or
> + 48 BCLKS per LRCLK.
> +
> + - reg : the I2C address of the device for I2C
> +
> +Example:
> +
> +codec: max98927@3a {
> + compatible = "maxim,max98927";
> + vmon-slot-no = <1>;
> + imon-slot-no = <0>;
> + reg = <0x3a>;
> +};
prev parent reply other threads:[~2016-11-28 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 18:13 [PATCH] ALSA SoC MAX98927 driver - Initial release kbuild test robot
2016-11-23 4:57 ` Ryan Lee
2016-11-23 15:46 ` Mark Brown
2016-11-23 17:51 ` kbuild test robot
2016-11-23 18:13 ` [PATCH] fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-11-23 18:56 ` [PATCH] ALSA SoC MAX98927 driver - Initial release kbuild test robot
2016-11-23 19:20 ` Michael Trimarchi
2016-11-25 5:02 ` [PATCH v2] ALSA SoC MAX98927 driver - Revision Ryan Lee
2016-11-30 18:15 ` Mark Brown
2016-11-28 22:01 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128220153.7ccbt4p3wy2fomis@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Damien.Horsley@imgtec.com \
--cc=RyanS.Lee@maximintegrated.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacob@teenage.engineering \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=nh6z@nh6z.net \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=petr@barix.com \
--cc=tiwai@suse.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).