From: Ingo Molnar <mingo@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Baolin Wang <baolin.wang@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Prarit Bhargava <prarit@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 4/7] time: alarmtimer: Add the tracepoints for alarmtimer
Date: Tue, 29 Nov 2016 08:23:59 +0100 [thread overview]
Message-ID: <20161129072359.GC29412@gmail.com> (raw)
In-Reply-To: <1480372524-15181-5-git-send-email-john.stultz@linaro.org>
* John Stultz <john.stultz@linaro.org> wrote:
> From: Baolin Wang <baolin.wang@linaro.org>
>
> For system debugging, we sometimes want to know who sets one
> alarm timer, the time of the timer, when the timer started and
> fired and so on. Thus adding tracepoints can help us trace the
> alarmtimer information.
s/one alarm timer/an alarm timer
> For example, when we debug the system supend/resume, if the
> system is always resumed by RTC alarm, we can find out which
> process set the alarm timer to resume system by below trace log:
s/when we debug the system/when we debug system
s/supend/suspend
s/resume system/resume the system
s/by below trace log/by the trace log below
> From the trace log, we can find out the 'Binder:3292_2' process
> set one alarm timer which resumes the system.
s/set one alarm timer/set an alarm timer
> Changes since v4:
> - Initialize 'type' to -1 and rename it in alarmtimer_suspend().
> - Fix typo in subject line.
>
> Changes since v3:
> - Remove the "ALARM_" prefix in the string.
> - Add the ACK by Steven Rostedt.
>
> Changes since v2:
> - Save time as s64 type.
> - Remove 'process_name' parameter and add 'now' parameter.
> - Rename the trace event name.
> - Remove restart trace event.
> - Other optimization.
I find it really sad that a patch that has gone through 4 iterations still has so
many typos and grammar errors in its changelog :-(
Thanks,
Ingo
next prev parent reply other threads:[~2016-11-29 7:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 22:35 [GIT PULL][PATCH 0/7] Timekeeping changes for 4.10 (take 2) John Stultz
2016-11-28 22:35 ` [PATCH 1/7] selftests/timers: Fix spelling mistake "Asyncrhonous" -> "Asynchronous" John Stultz
2016-11-29 17:10 ` [tip:timers/core] " tip-bot for Colin Ian King
2016-11-28 22:35 ` [PATCH 2/7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled John Stultz
2016-11-29 7:19 ` Ingo Molnar
2016-11-29 9:38 ` Chen Yu
2016-11-29 17:10 ` [tip:timers/core] " tip-bot for Chen Yu
2016-11-28 22:35 ` [PATCH 3/7] timekeeping: clocksource_cyc2ns: Document intended range limitation John Stultz
2016-11-29 17:11 ` [tip:timers/core] timekeeping/clocksource_cyc2ns: " tip-bot for Chris Metcalf
2016-11-28 22:35 ` [PATCH 4/7] time: alarmtimer: Add the tracepoints for alarmtimer John Stultz
2016-11-29 7:23 ` Ingo Molnar [this message]
2016-11-29 8:23 ` Baolin Wang
2016-11-29 9:12 ` Ingo Molnar
2016-11-29 11:52 ` Baolin Wang
2016-11-29 12:06 ` Thomas Gleixner
2016-11-30 11:43 ` Baolin Wang
2016-12-01 2:34 ` Baolin Wang
2016-12-01 13:52 ` [tip:timers/core] alarmtimer: Add tracepoints for alarm timers tip-bot for Baolin Wang
2016-11-28 22:35 ` [PATCH 5/7] timekeeping: Add a fast and NMI safe boot clock John Stultz
2016-11-29 17:11 ` [tip:timers/core] " tip-bot for Joel Fernandes
2016-11-28 22:35 ` [PATCH 6/7] trace: Add an option for boot clock as trace clock John Stultz
2016-11-28 23:05 ` Steven Rostedt
2016-11-29 17:12 ` [tip:timers/core] " tip-bot for Joel Fernandes
2016-11-28 22:35 ` [PATCH 7/7] trace: Update documentation for mono, mono_raw and boot clock John Stultz
2016-11-28 23:07 ` Steven Rostedt
2016-11-29 7:26 ` Ingo Molnar
2016-11-29 16:10 ` Joel Fernandes
2016-11-29 16:11 ` Thomas Gleixner
2016-11-29 17:13 ` [tip:timers/core] " tip-bot for Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129072359.GC29412@gmail.com \
--to=mingo@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).