From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Tin Huynh <tnhuynh@apm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, Loc Ho <lho@apm.com>,
Thang Nguyen <tqnguyen@apm.com>, Phong Vo <pvo@apm.com>,
patches@apm.com
Subject: Re: [PATCH V2] leds: pca963x: Add ACPI support
Date: Tue, 29 Nov 2016 13:04:00 +0200 [thread overview]
Message-ID: <20161129110400.GY1459@lahna.fi.intel.com> (raw)
In-Reply-To: <676881f2-07e1-9c77-3559-3cf9832852a6@samsung.com>
On Tue, Nov 29, 2016 at 11:55:47AM +0100, Jacek Anaszewski wrote:
> On 11/29/2016 11:21 AM, Tin Huynh wrote:
> > This patch enables ACPI support for leds-pca963x driver.
> >
> > Signed-off-by: Tin Huynh <tnhuynh@apm.com>
> > ---
> > drivers/leds/leds-pca963x.c | 25 ++++++++++++++++++++++++-
> > 1 files changed, 24 insertions(+), 1 deletions(-)
> >
> > Change from V1:
> > -Add CONFIG_ACPI.
> >
> > diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c
> > index 407eba1..57f11e3 100644
> > --- a/drivers/leds/leds-pca963x.c
> > +++ b/drivers/leds/leds-pca963x.c
> > @@ -25,6 +25,7 @@
> > * or by adding the 'nxp,hw-blink' property to the DTS.
> > */
> >
> > +#include <linux/acpi.h>
> > #include <linux/module.h>
> > #include <linux/delay.h>
> > #include <linux/string.h>
> > @@ -95,6 +96,17 @@ struct pca963x_chipdef {
> > };
> > MODULE_DEVICE_TABLE(i2c, pca963x_id);
> >
> > +#ifdef CONFIG_ACPI
> > +static const struct acpi_device_id pca963x_acpi_ids[] = {
> > + { "PCA9632", pca9633 },
> > + { "PCA9633", pca9633 },
> > + { "PCA9634", pca9634 },
> > + { "PCA9635", pca9635 },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(acpi, pca963x_acpi_ids);
> > +#endif
> > +
> > struct pca963x_led;
> >
> > struct pca963x {
> > @@ -322,7 +334,17 @@ static int pca963x_probe(struct i2c_client *client,
> > struct pca963x_chipdef *chip;
> > int i, err;
> >
> > - chip = &pca963x_chipdefs[id->driver_data];
> > + if (id) {
> > + chip = &pca963x_chipdefs[id->driver_data];
> > + } else {
> > + const struct acpi_device_id *acpi_id;
> > +
> > + acpi_id = acpi_match_device(ACPI_PTR(pca963x_acpi_ids),
> > + &client->dev);
>
> What kind of problem did you get while compiling without ACPI_PTR here,
> when CONFIG_ACPI is disabled? I also tried this configuration but
> nothing wrong happened. Also at first glance I don't see why lack of
> ACPI_PTR macro could cause problems.
>
> Grep also doesn't show any call to acpi_match_device
> with ACPI_PTR as the first argument in the existing drivers.
Indeed, that is not needed at all.
next prev parent reply other threads:[~2016-11-29 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161129102236epcas1p36ba8b4160c78cfd62d5748538174ca05@epcas1p3.samsung.com>
2016-11-29 10:21 ` [PATCH V2] leds: pca963x: Add ACPI support Tin Huynh
2016-11-29 10:47 ` Mika Westerberg
2016-11-29 10:55 ` Jacek Anaszewski
2016-11-29 11:04 ` Mika Westerberg [this message]
2016-11-29 14:47 ` Tin Huynh
2016-11-29 15:34 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129110400.GY1459@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=j.anaszewski@samsung.com \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patches@apm.com \
--cc=pvo@apm.com \
--cc=rjw@rjwysocki.net \
--cc=rpurdie@rpsys.net \
--cc=tnhuynh@apm.com \
--cc=tqnguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).