From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756834AbcK2NC3 (ORCPT ); Tue, 29 Nov 2016 08:02:29 -0500 Received: from mga04.intel.com ([192.55.52.120]:12824 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754236AbcK2NCT (ORCPT ); Tue, 29 Nov 2016 08:02:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,568,1473145200"; d="scan'208";a="196937980" Date: Tue, 29 Nov 2016 14:59:58 +0200 From: Heikki Krogerus To: Guenter Roeck Cc: Oliver Neukum , Badhri Jagan Sridharan , Greg KH , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCHv12 2/3] usb: USB Type-C connector class Message-ID: <20161129125958.GC32668@kuha.fi.intel.com> References: <20161122141147.21977-1-heikki.krogerus@linux.intel.com> <20161122141147.21977-3-heikki.krogerus@linux.intel.com> <20161124095755.GB17492@kuha.fi.intel.com> <1480328372.22547.8.camel@suse.com> <20161128142323.GA32668@kuha.fi.intel.com> <20161128201143.GB10709@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161128201143.GB10709@roeck-us.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote: > Personally I don't really care about a module parameter; as mentioned above, > I would expect the preference, if it needs to be selectable, to be configured > with devicetree or ACPI properties (or by a platform driver which sets a device > property). Unfortunately we can not assume the firmware to be always correct. Companies love to recycle the firmware. We are going to see products from a company X that should prefer source role, a desktop for example, but still give the OS a device property that says otherwise. The reason for that is most likely because the previous product from that company was some kind of mobile device. So IMHO we need some way for the OS to override this thing eventually. If not module parameters, then something else. The other option is board specific quirks, and I would really prefer to avoid those if we can. Thanks, -- heikki