From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH 0/4] tracing: Have tracepoint reg functions allowed to fail
Date: Tue, 29 Nov 2016 09:56:57 -0500 [thread overview]
Message-ID: <20161129145657.483474913@goodmis.org> (raw)
I added a 'trace_event=*:*' to my command line and it crashed the system.
The reason was because it enabled the tracepoint benchmark which has
a reg function that creates a thread. But the kernel command line
tracepoint enabling is done before the scheduler is set up, and thus
the creation of a thread killed the kernel.
But then I noticed that there's no way for the reg to tell the calling
function that it failed to set up. I changed that so that it can fail
and notify the users that the tracepoint did not get enabled due to
a failure.
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
ftrace/core
Head SHA1: 9d08cef4a375e171008ed3a041e930aae20cc940
Steven Rostedt (Red Hat) (4):
tracing: Have the reg function allow to fail
tracing: Do not start benchmark on boot up
tracing: Have system enable return error if one of the events fail
tracing: Allow benchmark to be enabled at early_initcall()
----
arch/powerpc/include/asm/trace.h | 4 ++--
arch/powerpc/platforms/powernv/opal-tracepoints.c | 6 ++++--
arch/powerpc/platforms/pseries/lpar.c | 6 ++++--
arch/x86/include/asm/trace/exceptions.h | 2 +-
arch/x86/include/asm/trace/irq_vectors.h | 2 +-
arch/x86/kernel/tracepoint.c | 3 ++-
drivers/i2c/i2c-core.c | 3 ++-
include/linux/tracepoint-defs.h | 2 +-
include/linux/tracepoint.h | 2 +-
include/trace/events/i2c.h | 2 +-
kernel/trace/trace_benchmark.c | 26 +++++++++++++++++++++--
kernel/trace/trace_benchmark.h | 2 +-
kernel/trace/trace_events.c | 13 ++++++++++--
kernel/tracepoint.c | 12 ++++++++---
samples/trace_events/trace-events-sample.c | 3 ++-
samples/trace_events/trace-events-sample.h | 2 +-
16 files changed, 67 insertions(+), 23 deletions(-)
next reply other threads:[~2016-11-29 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 14:56 Steven Rostedt [this message]
2016-11-29 14:56 ` [PATCH 1/4] tracing: Have the reg function allow to fail Steven Rostedt
2016-11-29 14:56 ` [PATCH 2/4] tracing: Do not start benchmark on boot up Steven Rostedt
2016-11-29 14:57 ` [PATCH 3/4] tracing: Have system enable return error if one of the events fail Steven Rostedt
2016-11-29 14:57 ` [PATCH 4/4] tracing: Allow benchmark to be enabled at early_initcall() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129145657.483474913@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).