archive mirror
 help / color / mirror / Atom feed
From: Gary Bisson <>
To: Fabio Estevam <>
Cc: Linus Walleij <>,
	Shawn Guo <>, Peng Fan <>,
	"" <>,
	linux-kernel <>,
	Pantelis Antoniou <>,
	Vladimir Zapolskiy <>
Subject: Re: [RFC] pinctrl: imx: use radix trees for groups and functions
Date: Wed, 30 Nov 2016 15:09:52 +0100	[thread overview]
Message-ID: <20161130140952.cjl3fxab2lejrh5m@t450s.lan> (raw)
In-Reply-To: <>

Hi Fabio, All,

On Wed, Nov 30, 2016 at 11:19:53AM -0200, Fabio Estevam wrote:
> Hi Gary,
> On Thu, Nov 24, 2016 at 9:38 PM, Gary Bisson
> <> wrote:
> > This change is inspired from the pinctrl-single architecture.
> >
> > The problem with current implementation is that it isn't possible
> > to add/remove functions and/or groups dynamically. The radix tree
> > offers an easy way to do so. The intent is to offer a follow-up
> > patch later that will enable the use of pinctrl nodes in dt-overlays.
> Maybe you could re-post it including the follow-up patch that allows
> the usage  of pinctrl nodes in dt-overlays?
> This way we can have a better picture of the final result.

Sure. But before doing so I'd like to share my findings after adding the

1- Needs to remove the const qualifier of info, otherwise each member is
read-only and can't be updated. Hope everybody is ok with that, but I
don't see any other option to be able to increase the number of

2- The way to get groups from a function (get_function_groups) makes it
hard to modify the number of groups of a specific function. Indeed it
would require re-alloc'ing the char**. Instead, it'd be best to make a
function for each group like it is done in pinctrl-single.
In this case, the function name would be the same as its single group
name. Then it is easy to add functions.

This approach looks good, IMO, when a device tree is using the "new
iomux scheme" since there's no real function. For the "legacy" scheme it
can be confusing since there are functions in the device tree (each
iomux sub-node). Is the legacy iomux scheme here to stay or is there a
plan to modify every device tree to comply to the new layout?

The other solution I came up with was that each overlay must have its
own function and cannot expand an existing function. This is an
unnecessary limitation in my opinion but I wanted to discuss it here
before submitting any of the two solutions.

My testing was done adding a dt-overlay pinctrl node, currently I'm not
sure how to cleanly remove a pinctrl function/group. It is not supported
in any of the pinctrl for now, but maybe it'd be a good time to think of

Let me know if you have any question.


  reply	other threads:[~2016-11-30 14:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 23:38 [RFC] pinctrl: imx: use radix trees for groups and functions Gary Bisson
2016-11-30 12:48 ` Linus Walleij
2016-11-30 13:19 ` Fabio Estevam
2016-11-30 14:09   ` Gary Bisson [this message]
2016-12-02 16:35 ` [RFC v2 0/3] pinctrl: imx: add support for dt-overlays Gary Bisson
2016-12-02 16:35   ` [RFC v2 1/3] pinctrl: imx: remove const qualifier of imx_pinctrl_soc_info Gary Bisson
2016-12-29 11:23     ` Fabio Estevam
2016-12-30 13:23     ` Linus Walleij
2016-12-02 16:35   ` [RFC v2 2/3] pinctrl: imx: use radix trees for groups and functions Gary Bisson
2016-12-27 13:05     ` Linus Walleij
2016-12-27 13:11       ` Fabio Estevam
2016-12-27 22:07     ` Linus Walleij
2016-12-29  9:44       ` Gary Bisson
2016-12-30 13:21         ` Linus Walleij
2016-12-30 13:25     ` Linus Walleij
2016-12-02 16:35   ` [RFC v2 3/3] pinctrl: imx: add of_notifier for dynamic pinctrl changes Gary Bisson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130140952.cjl3fxab2lejrh5m@t450s.lan \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).