From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Florian Vaussard <florian.vaussard@gmail.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
<alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>,
Florian Vaussard <florian.vaussard@heig-vd.ch>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits
Date: Thu, 1 Dec 2016 09:42:00 +0000 [thread overview]
Message-ID: <20161201094200.GK1867@localhost.localdomain> (raw)
In-Reply-To: <1480439449-15975-1-git-send-email-florian.vaussard@heig-vd.ch>
On Tue, Nov 29, 2016 at 06:10:49PM +0100, Florian Vaussard wrote:
> Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k)
> and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform
> (mask & 1), which results in 0 if LSB of mask is 0. Thus the call
> regmap_update_bits(..., mask, 1) is in reality equivalent to
> regmap_update_bits(..., mask, 0).
>
> In such a case, the correct use is regmap_update_bits(..., mask, mask).
>
> This driver is performing such a mistake with the CS42L56_AIN*_REF_MASK
> masks, which equal 0x10, 0x20, 0x40 and 0x80. Fix the driver to make it
> consistent with the API. Please note that this change is untested,
> as I do not have this piece of hardware. Testers are welcome!
>
> Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch>
> ---
Looks good to me:
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2016-12-01 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 17:10 [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits Florian Vaussard
2016-12-01 9:42 ` Charles Keepax [this message]
2016-12-01 14:57 ` [alsa-devel] " Brian Austin
2016-12-05 13:53 ` Applied "ASoC: cs42l56: Fix misuse of regmap_update_bits" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201094200.GK1867@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=florian.vaussard@gmail.com \
--cc=florian.vaussard@heig-vd.ch \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).