From: Stefan Hajnoczi <stefanha@redhat.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Luonengjun <luonengjun@huawei.com>,
"mst@redhat.com" <mst@redhat.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"Wubin (H)" <wu.wubin@huawei.com>,
"xin.zeng@intel.com" <xin.zeng@intel.com>,
Claudio Fontana <Claudio.Fontana@huawei.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"pasic@linux.vnet.ibm.com" <pasic@linux.vnet.ibm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Zhoujian (jay, Euler)" <jianjay.zhou@huawei.com>,
"Hanweidong (Randy)" <hanweidong@huawei.com>,
"arei.gonglei@hotmail.com" <arei.gonglei@hotmail.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"Xuquan (Quan Xu)" <xuquan8@huawei.com>,
longpeng <longpeng2@huawei.com>,
"salvatore.benedetto@intel.com" <salvatore.benedetto@intel.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>
Subject: Re: [PATCH v4 1/1] crypto: add virtio-crypto driver
Date: Thu, 1 Dec 2016 11:53:27 +0000 [thread overview]
Message-ID: <20161201115327.GB10441@stefanha-x1.localdomain> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020DA14EC02@DGGEMA505-MBX.china.huawei.com>
[-- Attachment #1: Type: text/plain, Size: 2675 bytes --]
On Thu, Dec 01, 2016 at 02:27:19AM +0000, Gonglei (Arei) wrote:
> > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote:
> > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c
> > b/drivers/crypto/virtio/virtio_crypto_algs.c
> > > new file mode 100644
> > > index 0000000..08b077f
> > > --- /dev/null
> > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.c
> > > @@ -0,0 +1,518 @@
> > > + /* Algorithms supported by virtio crypto device
> > > + *
> > > + * Authors: Gonglei <arei.gonglei@huawei.com>
> > > + *
> > > + * Copyright 2016 HUAWEI TECHNOLOGIES CO., LTD.
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation; either version 2 of the License, or
> > > + * (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * You should have received a copy of the GNU General Public License
> > > + * along with this program; if not, see <http://www.gnu.org/licenses/>.
> > > + */
> > > +
> > > +#include <linux/scatterlist.h>
> > > +#include <crypto/algapi.h>
> > > +#include <linux/err.h>
> > > +#include <crypto/scatterwalk.h>
> > > +#include <linux/atomic.h>
> > > +
> > > +#include <uapi/linux/virtio_crypto.h>
> > > +#include "virtio_crypto_common.h"
> > > +
> > > +static DEFINE_MUTEX(algs_lock);
> >
> > Did you run checkpatch.pl? I think it encourages you to document what
> > the lock protects.
> >
> Sure. Basically I run checkpatch.py each time. :)
>
> # ./scripts/checkpatch.pl 0001-crypto-add-virtio-crypto-driver.patch
> total: 0 errors, 0 warnings, 1873 lines checked
>
> 0001-crypto-add-virtio-crypto-driver.patch has no obvious style problems and is ready for submission.
Looks like a bug in checkpatch.pl:
# check for spinlock_t definitions without a comment.
if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
$line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
my $which = $1;
if (!ctx_has_comment($first_line, $linenr)) {
CHK("UNCOMMENTED_DEFINITION",
"$1 definition without comment\n" . $herecurr);
}
}
Since your mutex definition has the 'static' keyword in front of it
checkpatch.pl misses it!
Andy: Is this checkpatch.pl behavior intentional?
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-12-01 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 12:48 [PATCH v4 0/1] virtio-crypto: add Linux driver Gonglei
2016-11-29 12:48 ` [PATCH v4 1/1] crypto: add virtio-crypto driver Gonglei
2016-11-30 11:09 ` Stefan Hajnoczi
2016-12-01 2:27 ` Gonglei (Arei)
2016-12-01 11:53 ` Stefan Hajnoczi [this message]
2016-12-01 12:33 ` Gonglei (Arei)
2016-12-01 11:58 ` Stefan Hajnoczi
2016-12-01 12:23 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201115327.GB10441@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=Claudio.Fontana@huawei.com \
--cc=apw@shadowen.org \
--cc=arei.gonglei@hotmail.com \
--cc=arei.gonglei@huawei.com \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=hanweidong@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=jianjay.zhou@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=salvatore.benedetto@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=weidong.huang@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xin.zeng@intel.com \
--cc=xuquan8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).