From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756141AbcLAMNB (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Dec 2016 07:13:01 -0500
Received: from mx2.suse.de ([195.135.220.15]:57129 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750831AbcLAMNA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Dec 2016 07:13:00 -0500
Date: Thu, 1 Dec 2016 13:12:56 +0100
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        Tejun Heo <tj@kernel.org>, Calvin Owens <calvinowens@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mel Gorman <mgorman@techsingularity.net>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Laura Abbott <labbott@redhat.com>, Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCHv4 2/6] printk: rename nmi.c and exported api
Message-ID: <20161201121256.GM21230@pathway.suse.cz>
References: <20161027154933.1211-1-sergey.senozhatsky@gmail.com>
 <20161027154933.1211-3-sergey.senozhatsky@gmail.com>
 <20161124163501.GF24103@pathway.suse.cz>
 <20161201010701.GC12039@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161201010701.GC12039@jagdpanzerIV>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu 2016-12-01 10:07:01, Sergey Senozhatsky wrote:
> On (11/24/16 17:35), Petr Mladek wrote:
> [..]
> > >  #ifdef CONFIG_PRINTK_NMI
> > > -extern void printk_nmi_init(void);
> > > -extern void printk_nmi_enter(void);
> > > -extern void printk_nmi_exit(void);
> > > -extern void printk_nmi_flush(void);
> > > -extern void printk_nmi_flush_on_panic(void);
> > > +extern void printk_safe_init(void);
> > > +extern void printk_safe_nmi_enter(void);
> > > +extern void printk_safe_nmi_exit(void);
> > 
> > I would personally keep the short names pritnk_nmi_enter() and
> > printk_nmi_exit(). These are the only functions that will stay
> > in this CONFIG_PRINT_NMI section. The others are generic and
> > will be moved to the generic section in the next patch.
> 
> I'd probably prefer all printk_safe functions to be printk_safe
> prefixed, just to show the fact that those are printk_safe
> functions (IOW, indirect output to a per-CPU buffer and flush
> it to logbuf later).

Fair enough.

Best regards,
Petr