From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756532AbcLBKGD (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Dec 2016 05:06:03 -0500
Received: from mx2.suse.de ([195.135.220.15]:42749 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751296AbcLBKGB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Dec 2016 05:06:01 -0500
Date: Fri, 2 Dec 2016 11:05:58 +0100
From: Petr Mladek <pmladek@suse.com>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: Sebastian Duda <sebastian.duda@fau.de>, linux-kernel@i4.cs.fau.de,
        Tobias Baumeister <tobias.baumeister@fau.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Borislav Petkov <bp@suse.de>, Tejun Heo <tj@kernel.org>,
        Thierry Reding <treding@nvidia.com>,
        open list <linux-kernel@vger.kernel.org>, lkp@01.org
Subject: Re: [lkp] [printk.c]  ea0639c4d5: BUG:recent_printk_recursion
Message-ID: <20161202100558.GR21230@pathway.suse.cz>
References: <1480432743-8049-1-git-send-email-sebastian.duda@fau.de>
 <20161201171232.GD31607@yexl-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161201171232.GD31607@yexl-desktop>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri 2016-12-02 01:12:32, kernel test robot wrote:
> 
> FYI, we noticed the following commit:
> 
> commit: ea0639c4d5c700ad63c0ace6a7a17877aac5b4c2 ("printk.c: removed unnecessary code")
> url: https://github.com/0day-ci/linux/commits/Sebastian-Duda/printk-c-removed-unnecessary-code/20161130-225006
> 
> 
> in testcase: trinity
> with following parameters:
> 
> 	runtime: 300s
> 
> test-description: Trinity is a linux system call fuzz tester.
> test-url: http://codemonkey.org.uk/projects/trinity/
> 
> 
> on test machine: qemu-system-i386 -enable-kvm -m 256M
> 
> caused below changes:
> 
> 
> +-------------------------------------------------------+------------+------------+
> |                                                       | ded6e842cf | ea0639c4d5 |
> +-------------------------------------------------------+------------+------------+
> | boot_successes                                        | 19         | 8          |
> | boot_failures                                         | 3          | 49         |

I am not surprised. The patch breaks counting of the space
needed to print the message. It is likely to cause buffer
overflows. I have already nacked it, see
https://lkml.kernel.org/r/20161130102231.GE24060@pathway.suse.cz

Anyway, thanks for testing.

Best Regards,
Petr