linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Oliver Neukum <oneukum@suse.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv13 2/3] usb: USB Type-C connector class
Date: Fri, 2 Dec 2016 19:22:10 +0100	[thread overview]
Message-ID: <20161202182210.GA18111@kroah.com> (raw)
In-Reply-To: <20161202180439.GA25991@roeck-us.net>

On Fri, Dec 02, 2016 at 10:04:39AM -0800, Guenter Roeck wrote:
> The driver interface is not my area of expertise. As such, my testing
> and understanding of that part was limited to "it appears to work,
> it must be ok". I very much relied on you to get this part right.
> 
> That makes me feel really bad. It isn't fun to have my "Reviewed-by"
> on a patch that gets (and apparently deserves) a WTF from a senior
> kernel maintainer. This hurts both your and my reputation, and obviously
> will make me quite hesitant to add a "Reviewed-by:" to the next version
> of the series.

Hey, it doesn't bother me at all, I want and need your reviews of those
portions that I don't know as well (i.e. the userspace api and
functionality.)   So don't take it personally, the driver model isn't
that easy of a topic to mess with in places, loads of people get it
wrong.

> No more shortcuts, please.

I totally agree :)

Also, I want some Intel reviews on this, that should help make a lot of
these types of issues go away...

thanks,

greg k-h

  reply	other threads:[~2016-12-02 18:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 12:21 [PATCHv13 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-12-07 23:54   ` [PATCHv13,1/3] " Guenter Roeck
2016-12-08  7:29     ` Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-29 16:27   ` Greg KH
2016-11-30  9:19     ` Heikki Krogerus
2016-12-02 18:04       ` Guenter Roeck
2016-12-02 18:22         ` Greg KH [this message]
2016-12-07  9:11         ` Heikki Krogerus
2016-12-07  9:46         ` Oliver Neukum
2016-12-07 12:52           ` Heikki Krogerus
2016-12-15 11:50             ` Heikki Krogerus
2016-12-15 12:06               ` Oliver Neukum
2016-12-15 15:01               ` Guenter Roeck
2016-12-19 14:45                 ` [RFC PATCH] " Heikki Krogerus
2016-12-19 17:22                   ` Guenter Roeck
2016-12-20 14:23                     ` Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161202182210.GA18111@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).