From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbcLDCr5 (ORCPT ); Sat, 3 Dec 2016 21:47:57 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34661 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbcLDCrz (ORCPT ); Sat, 3 Dec 2016 21:47:55 -0500 From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , Steven Allen , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: [PATCH] zram: restrict add/remove attributes to root only Date: Sun, 4 Dec 2016 11:35:15 +0900 Message-Id: <20161204023515.7740-1-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only root must be able to create a new zram device, therefore hot_add attribute must have S_IRUSR mode, not S_IRUGO. Otherwise, anyone can create a new zram device (device initialization with the disksize attr requires root permission). Fixes: 6566d1a32bf72 ("zram: add dynamic device add/remove functionality") Reported-by: Steven Allen Cc: [4.2+] Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 5163c8f..ee03464 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1414,8 +1414,8 @@ static ssize_t hot_remove_store(struct class *class, } static struct class_attribute zram_control_class_attrs[] = { - __ATTR_RO(hot_add), - __ATTR_WO(hot_remove), + __ATTR(hot_add, 0400, hot_add_show, NULL), + __ATTR(hot_remove, 0200, NULL, hot_remove_store), __ATTR_NULL, }; -- 2.10.2