From: Fernando Apesteguia <fernando.apesteguia@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters
Date: Sun, 4 Dec 2016 20:06:26 +0100 [thread overview]
Message-ID: <20161204190626.GA2531@erazer> (raw)
In-Reply-To: <20161203101123.GB13906@kroah.com>
On Sat, Dec 03, 2016 at 11:11:23AM +0100, Greg KH wrote:
> On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote:
> > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote:
> > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote:
> > > > For the first lines of the patch, I opted to create a small function
> > > > instead of breaking the the line in a weird way.
> > > >
> > > > The other changes are simple ones.
> > > >
> > > > Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> > > > ---
> > > > drivers/staging/dgnc/dgnc_tty.c | 42 +++++++++++++++++++++++++----------------
> > > > 1 file changed, 26 insertions(+), 16 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> > > > index af4bc86..835d448 100644
> > > > --- a/drivers/staging/dgnc/dgnc_tty.c
> > > > +++ b/drivers/staging/dgnc/dgnc_tty.c
> > > > @@ -102,6 +102,7 @@ static int dgnc_tty_write(struct tty_struct *tty, const unsigned char *buf,
> > > > static void dgnc_tty_set_termios(struct tty_struct *tty,
> > > > struct ktermios *old_termios);
> > > > static void dgnc_tty_send_xchar(struct tty_struct *tty, char ch);
> > > > +static void dgnc_keep_line_low(struct channel_t *ch, const unsigned char line);
> > > >
> > > > static const struct tty_operations dgnc_tty_ops = {
> > > > .open = dgnc_tty_open,
> > > > @@ -786,6 +787,12 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
> > > > }
> > > > }
> > > >
> > > > +static void dgnc_keep_line_low(struct channel_t *ch, const unsigned char line)
> > > > +{
> > > > + ch->ch_mostat &= ~(line);
> > > > + ch->ch_bd->bd_ops->assert_modem_signals(ch);
> > > > +}
> > >
> > > Your name here is odd, it is named because of what it does to the coding
> > > style, not to the logic of what is happening in the function itself,
> > > making it very confusing.
> >
> > It was a bad choice indeed :) but I didn't mean anything about the coding
> > style but about what the fuction does. It was meant to be read as:
> > "keep_signal_low" since the function puts (RTS/DTR) UART "line" to low.
> >
> > Would "keep_signal_low" be clear and representative of what the function does?
>
> It's not "keep", it is "change", right? I don't remember the context
> now, sorry, you could be correct...
Yes, I think "change" or even "set" would be more appropriate. I'll rework the
patch and send it again.
Thanks.
>
>
> greg k-h
next prev parent reply other threads:[~2016-12-04 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:13 [PATCH] staging: dgnc: Fix lines longer than 80 characters Fernando Apesteguia
2016-12-03 8:51 ` Greg KH
2016-12-03 9:56 ` Fernando Apesteguia
2016-12-03 10:11 ` Greg KH
2016-12-04 19:06 ` Fernando Apesteguia [this message]
2016-12-05 20:51 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2016-09-28 17:20 Fernando Apesteguia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204190626.GA2531@erazer \
--to=fernando.apesteguia@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).