From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbcLFAoV (ORCPT ); Mon, 5 Dec 2016 19:44:21 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:58498 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbcLFAoT (ORCPT ); Mon, 5 Dec 2016 19:44:19 -0500 Date: Mon, 05 Dec 2016 19:44:14 -0500 (EST) Message-Id: <20161205.194414.1922270027505338684.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: xiyou.wangcong@gmail.com, andreyknvl@google.com, johannes.berg@intel.com, fw@strlen.de, edumazet@google.com, me@bobcopeland.com, tom@herbertland.com, decot@googlers.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v3 PATCH] netlink: Do not schedule work from sk_destruct From: David Miller In-Reply-To: <20161205072820.GB10204@gondor.apana.org.au> References: <20161205071946.GB9496@gondor.apana.org.au> <20161205072600.GA10204@gondor.apana.org.au> <20161205072820.GB10204@gondor.apana.org.au> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Dec 2016 15:44:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Mon, 5 Dec 2016 15:28:21 +0800 > It is wrong to schedule a work from sk_destruct using the socket > as the memory reserve because the socket will be freed immediately > after the return from sk_destruct. > > Instead we should do the deferral prior to sk_free. > > This patch does just that. > > Fixes: 707693c8a498 ("netlink: Call cb->done from a worker thread") > Signed-off-by: Herbert Xu Applied, thanks Herbert.