From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751530AbcLECnX (ORCPT <rfc822;w@1wt.eu>);
        Sun, 4 Dec 2016 21:43:23 -0500
Received: from mga06.intel.com ([134.134.136.31]:6934 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751195AbcLECnU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 4 Dec 2016 21:43:20 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,302,1477983600"; 
   d="asc'?scan'208";a="1077435961"
Date: Mon, 5 Dec 2016 10:38:07 +0800
From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Eric Engestrom <eric@engestrom.ch>
Cc: linux-kernel@vger.kernel.org, Pei Zhang <pei.zhang@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>, Zhi Wang <zhi.a.wang@intel.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>, igvt-g-dev@ml01.01.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s
 error path
Message-ID: <20161205023807.syha6i23skstqmhd@zhen-hp.sh.intel.com>
Reply-To: Zhenyu Wang <zhenyuw@linux.intel.com>
References: <20161204235718.1102-1-eric@engestrom.ch>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="4eqgt54nzo2fnuel"
Content-Disposition: inline
In-Reply-To: <20161204235718.1102-1-eric@engestrom.ch>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--4eqgt54nzo2fnuel
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2016.12.04 23:57:18 +0000, Eric Engestrom wrote:
> 90d27a1 moved the lock before this error path but forgot to add an
> unlock here.
>=20
> Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thre=
ad")
> Cc: Pei Zhang <pei.zhang@intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Signed-off-by: Eric Engestrom <eric@engestrom.ch>
> ---

Hi, this has been fixed on https://cgit.freedesktop.org/drm/drm-intel/commi=
t/?h=3Ddrm-intel-next-fixes&id=3D53d6f812c0dbf1c9cad89b1c2118e61c13ca9677

Thanks!

>  drivers/gpu/drm/i915/gvt/scheduler.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/=
gvt/scheduler.c
> index f898df3..cd13c4b 100644
> --- a/drivers/gpu/drm/i915/gvt/scheduler.c
> +++ b/drivers/gpu/drm/i915/gvt/scheduler.c
> @@ -177,6 +177,7 @@ static int dispatch_workload(struct intel_vgpu_worklo=
ad *workload)
>  	rq =3D i915_gem_request_alloc(dev_priv->engine[ring_id], shadow_ctx);
>  	if (IS_ERR(rq)) {
>  		gvt_err("fail to allocate gem request\n");
> +		mutex_unlock(&dev_priv->drm.struct_mutex);
>  		workload->status =3D PTR_ERR(rq);
>  		return workload->status;
>  	}
> --=20
> Cheers,
>   Eric
>=20

--=20
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

--4eqgt54nzo2fnuel
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAlhE0w8ACgkQsQQaM014GCc4zQCgjbmTQ+4SdBmE5VBNlP24yuiP
lc4AnimI4ftOwL6CQ+KVtgbJ0J6pvPhB
=DIIC
-----END PGP SIGNATURE-----

--4eqgt54nzo2fnuel--