linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: jun.nie@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com,
	viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	xie.baoyou@zte.com.cn, chen.chaokai@zte.com.cn,
	wang.qiang01@zte.com.cn
Subject: Re: [PATCH] arm64: dts: zx: add pcu_domain node for zx296718
Date: Mon, 5 Dec 2016 11:16:41 +0800	[thread overview]
Message-ID: <20161205031639.GB2667@dragon> (raw)
In-Reply-To: <1480766354-25168-1-git-send-email-baoyou.xie@linaro.org>

On Sat, Dec 03, 2016 at 07:59:14PM +0800, Baoyou Xie wrote:
> This patch adds the pcu_domain node, so it can be used
> by zte-soc's power domain driver.
> 
> Furthermore, it adds the document of the node.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/zte.txt | 11 +++++++++++

DT bindings doc should be a separate patch, and goes together with
driver changes using the bindings through subsystem maintainers, rather
than dts patches.

>  arch/arm64/boot/dts/zte/zx296718.dtsi         |  7 +++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/zte.txt b/Documentation/devicetree/bindings/arm/zte.txt
> index 83369785..19a7e1b 100644
> --- a/Documentation/devicetree/bindings/arm/zte.txt
> +++ b/Documentation/devicetree/bindings/arm/zte.txt
> @@ -27,6 +27,9 @@ System management required properties:
>        - compatible = "zte,zx296718-aon-sysctrl"
>        - compatible = "zte,zx296718-sysctrl"
>  
> +Low power management required properties:
> +      - compatible = "zte,zx296718-pcu"
> +
>  Example:
>  aon_sysctrl: aon-sysctrl@116000 {
>  	compatible = "zte,zx296718-aon-sysctrl", "syscon";
> @@ -37,3 +40,11 @@ sysctrl: sysctrl@1463000 {
>  	compatible = "zte,zx296718-sysctrl", "syscon";
>  	reg = <0x1463000 0x1000>;
>  };
> +
> +pcu_domain: pcu@0x00117000 {
> +        compatible = "zte,zx296718-pcu";
> +        reg = <0x00117000 0x1000>;
> +        #power-domain-cells = <1>;
> +        status = "ok";
> +};
> +

I think we should have a separate bindings doc for PCU power domain
block in Documentation/devicetree/bindings/soc/zte.

> diff --git a/arch/arm64/boot/dts/zte/zx296718.dtsi b/arch/arm64/boot/dts/zte/zx296718.dtsi
> index b44d1d1..39e70c7 100644
> --- a/arch/arm64/boot/dts/zte/zx296718.dtsi
> +++ b/arch/arm64/boot/dts/zte/zx296718.dtsi
> @@ -351,5 +351,12 @@
>  			reg = <0x01480000 0x1000>;
>  			#clock-cells = <1>;
>  		};
> +
> +		pcu_domain: pcu@0x00117000 {

Please drop the 0x and leading zeros in unit-address after node name.
That said, the node name should be written like below:

	pcu@117000 {

Also, please sort the node with unit-address in order of the address.
That means that pcu node should be put after aon-sysctrl@116000.

> +			compatible = "zte,zx296718-pcu";
> +			reg = <0x00117000 0x1000>;
> +			#power-domain-cells = <1>;
> +			status = "ok";

The property 'status' is generally used to enable devices that have
board-level pin-out or configuration in board dts.  It's not really
necessary for pcu here.

Shawn

> +		};
>  	};
>  };
> -- 
> 2.7.4
> 

      reply	other threads:[~2016-12-05  3:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03 11:59 [PATCH] arm64: dts: zx: add pcu_domain node for zx296718 Baoyou Xie
2016-12-05  3:16 ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161205031639.GB2667@dragon \
    --to=shawnguo@kernel.org \
    --cc=baoyou.xie@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=chen.chaokai@zte.com.cn \
    --cc=devicetree@vger.kernel.org \
    --cc=jun.nie@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=wang.qiang01@zte.com.cn \
    --cc=will.deacon@arm.com \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).