From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbcLEP1z (ORCPT ); Mon, 5 Dec 2016 10:27:55 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:53072 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcLEP1y (ORCPT ); Mon, 5 Dec 2016 10:27:54 -0500 Date: Mon, 5 Dec 2016 16:27:52 +0100 From: Alexandre Belloni To: Emil Bartczak Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] rtc: mcp795: use bcd2bin/bin2bcd. Message-ID: <20161205152752.btnbja25daxn2dha@piout.net> References: <1c3a3f47c0316b2bf02e762d0990de1aab23d828.1480939487.git.emilbart@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c3a3f47c0316b2bf02e762d0990de1aab23d828.1480939487.git.emilbart@gmail.com> User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2016 at 14:11:53 +0100, Emil Bartczak wrote : > Change rtc-mcp795.c to use the bcd2bin/bin2bcd functions. > --- > drivers/rtc/rtc-mcp795.c | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) > > diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc-mcp795.c > index c9ad46c..1d823f9 100644 > --- a/drivers/rtc/rtc-mcp795.c > +++ b/drivers/rtc/rtc-mcp795.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > /* MCP795 Instructions, see datasheet table 3-1 */ > #define MCP795_EEREAD 0x03 > @@ -137,7 +138,6 @@ static int mcp795_start_oscillator(struct device *dev) > > static int mcp795_set_time(struct device *dev, struct rtc_time *tim) > { > - int month; You just introduced this variable to fix a bug. Maybe it was not necessary? -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com