From: Greg KH <gregkh@linuxfoundation.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Steven Allen <steven@stebalien.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCHv3] zram: restrict add/remove attributes to root only
Date: Mon, 5 Dec 2016 17:50:21 +0100 [thread overview]
Message-ID: <20161205165021.GA20595@kroah.com> (raw)
In-Reply-To: <20161205155845.20129-1-sergey.senozhatsky@gmail.com>
On Tue, Dec 06, 2016 at 12:58:45AM +0900, Sergey Senozhatsky wrote:
> zram hot_add sysfs attribute is a very 'special' attribute - reading
> from it creates a new uninitialized zram device. This file, by a mistake,
> can be read by a 'normal' user at the moment, while only root must be
> able to create a new zram device, therefore hot_add attribute must have
> S_IRUSR mode, not S_IRUGO.
>
> Fixes: 6566d1a32bf72 ("zram: add dynamic device add/remove functionality")
> Reported-by: Steven Allen <steven@stebalien.com>
> Cc: <stable@vger.kernel.org> [4.2+]
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2016-12-05 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 12:44 [PATCHv2] zram: restrict add/remove attributes to root only Sergey Senozhatsky
2016-12-05 12:57 ` Greg KH
2016-12-05 15:57 ` Sergey Senozhatsky
2016-12-05 15:58 ` [PATCHv3] " Sergey Senozhatsky
2016-12-05 16:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205165021.GA20595@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).