From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbcLEUv7 (ORCPT ); Mon, 5 Dec 2016 15:51:59 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:49683 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbcLEUv6 (ORCPT ); Mon, 5 Dec 2016 15:51:58 -0500 Date: Mon, 5 Dec 2016 23:51:16 +0300 From: Dan Carpenter To: Fernando Apesteguia Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters Message-ID: <20161205205116.GA31322@mwanda> References: <1480706029-28267-1-git-send-email-fernando.apesteguia@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480706029-28267-1-git-send-email-fernando.apesteguia@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. These first ones are the nice. > @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd, > if (ch->ch_tun.un_flags & (UN_LOW | UN_EMPTY)) { > ch->ch_tun.un_flags &= > ~(UN_LOW | UN_EMPTY); > - wake_up_interruptible(&ch->ch_tun.un_flags_wait); > + wake_up_interruptible(&ch->ch_tun > + .un_flags_wait); Ugh... No. Don't do this. Just let it go over 80 characters. Ignore the warning. regards, dan carpenter