From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752992AbcLEWbX (ORCPT ); Mon, 5 Dec 2016 17:31:23 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34731 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbcLEWbU (ORCPT ); Mon, 5 Dec 2016 17:31:20 -0500 Date: Mon, 5 Dec 2016 23:31:16 +0100 From: Emil Bartczak To: Alexandre Belloni Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting. Message-ID: <20161205223116.GC15764@emba-laptop> References: <9d5792a4e183cdea55accd6747b55f54d9e9d6aa.1480939487.git.emilbart@gmail.com> <20161205150959.gx5ccrfcvb5an7lx@piout.net> <20161205220352.GB15449@emba-laptop> <20161205221559.ixqsqsqnupgjtekk@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161205221559.ixqsqsqnupgjtekk@piout.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 05, 2016 at 11:15:59PM +0100, Alexandre Belloni wrote: > On 05/12/2016 at 23:03:52 +0100, Emil Bartczak wrote : > > > > > > > #define MCP795_WRITE 0x12 > > > > #define MCP795_UNLOCK 0x14 > > > > #define MCP795_IDWRITE 0x32 > > > > @@ -39,6 +39,7 @@ > > > > > > > > #define MCP795_ST_BIT 0x80 > > > > #define MCP795_24_BIT 0x40 > > > > +#define MCP795_LP_BIT 0x20 > > > > > > > > static int mcp795_rtcc_read(struct device *dev, u8 addr, u8 *buf, u8 count) > > > > { > > > > @@ -108,7 +109,8 @@ static int mcp795_set_time(struct device *dev, struct rtc_time *tim) > > > > data[1] = (data[1] & 0x80) | ((tim->tm_min / 10) << 4) | (tim->tm_min % 10); > > > > data[2] = ((tim->tm_hour / 10) << 4) | (tim->tm_hour % 10); > > > > data[4] = ((tim->tm_mday / 10) << 4) | ((tim->tm_mday) % 10); > > > > - data[5] = (data[5] & 0x10) | (tim->tm_mon / 10) | (tim->tm_mon % 10); > > > > + data[5] = (data[5] & MCP795_LP_BIT) | > > > > > > You changed 0x10 in MCP795_LP_BIT which you defined as 0x20, is that > > > right? > > Yes, it should be 0x20 (checked in datasheet). > > > > > > > > This is also an unrelated change. > > > > > > > + ((tim->tm_mon / 10) << 4) | (tim->tm_mon % 10); > > What do you mean exactly? > > That above line of code was moved to the new line? Or that I added > > shift left operation (tim->tm_mon / 10) << 4)? > > Changing 0x10 to 0x20 and adding shift right operation fixes the problem. > > > > I meant that I feel like changing 0x10 to 0x20 is a separate bugfix from > adding the shift. At least mention that in the commit message. Ok, I will improve commit message. > > > > > > > > > if (tim->tm_year > 100) > > > > tim->tm_year -= 100; > > > > @@ -137,11 +139,11 @@ static int mcp795_read_time(struct device *dev, struct rtc_time *tim) > > > > if (ret) > > > > return ret; > > > > > > > > - tim->tm_sec = ((data[0] & 0x70) >> 4) * 10 + (data[0] & 0x0f); > > > > - tim->tm_min = ((data[1] & 0x70) >> 4) * 10 + (data[1] & 0x0f); > > > > + tim->tm_sec = ((data[0] & 0x70) >> 4) * 10 + (data[0] & 0x0f); > > > > + tim->tm_min = ((data[1] & 0x70) >> 4) * 10 + (data[1] & 0x0f); > > > > tim->tm_hour = ((data[2] & 0x30) >> 4) * 10 + (data[2] & 0x0f); > > > > tim->tm_mday = ((data[4] & 0x30) >> 4) * 10 + (data[4] & 0x0f); > > > > - tim->tm_mon = ((data[5] & 0x10) >> 4) * 10 + (data[5] & 0x0f); > > > > + tim->tm_mon = ((data[5] & 0x10) >> 4) * 10 + (data[5] & 0x0f); > > > > > > All those whitespace changes are actually confusing. Please do them in a > > > separate patch or in your last patch. > > Ok, I will have a separate patch for them. > > Maybe switching to bcd2bin/bin2bcd first is better as it touches all > those lines anyway and also solves the shift in mcp795_rtcc_read() Yes, this is a good idea. I will prepare a new patchset where first patch will provide switching to bcd2bin/bin2bcd. > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com Emil,