From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753756AbcLFPp0 (ORCPT ); Tue, 6 Dec 2016 10:45:26 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:42048 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbcLFPpY (ORCPT ); Tue, 6 Dec 2016 10:45:24 -0500 Date: Tue, 06 Dec 2016 10:44:00 -0500 (EST) Message-Id: <20161206.104400.2131603846152593015.davem@davemloft.net> To: mikko.rapeli@iki.fi Cc: jonas.gorski@gmail.com, linux-kernel@vger.kernel.org, zhangshengju@cmss.chinamobile.com Subject: Re: [PATCH] uapi glibc compat: fix outer guard of net device flags enum From: David Miller In-Reply-To: <20161205173401.GU8342@lakka.kapsi.fi> References: <1480782705-2638-1-git-send-email-jonas.gorski@gmail.com> <20161205173401.GU8342@lakka.kapsi.fi> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Dec 2016 06:44:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mikko Rapeli Date: Mon, 5 Dec 2016 19:34:02 +0200 > On Sat, Dec 03, 2016 at 05:31:45PM +0100, Jonas Gorski wrote: >> Fix a wrong condition preventing the higher net device flags >> IFF_LOWER_UP etc to be defined if net/if.h is included before >> linux/if.h. >> >> The comment makes it clear the intention was to allow partial >> definition with either parts. >> >> This fixes compilation of userspace programs trying to use >> IFF_LOWER_UP, IFF_DORMANT or IFF_ECHO. >> >> Fixes: 4a91cb61bb99 ("uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h") >> Signed-off-by: Jonas Gorski > > Reviewed-by: Mikko Rapeli > > Yep, sorry about the logic error. Thanks for the fix! Applied. Jonas, please properly put netdev@vger.kernel.org on the CC: for networking patches in the future. Thank you.