From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
Minchan Kim <minchan@kernel.org>
Subject: [PATCH 07/10] perf sched timehist: Save callchain when entering idle
Date: Tue, 6 Dec 2016 12:40:07 +0900 [thread overview]
Message-ID: <20161206034010.6499-8-namhyung@kernel.org> (raw)
In-Reply-To: <20161206034010.6499-1-namhyung@kernel.org>
In order to investigate reason of idle, it needs to keep the callchains
when entering to idle. This can be identified sched_switch event having
next_pid as 0.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-sched.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index d3ee814ce77f..058cb549cf3e 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -200,6 +200,7 @@ struct perf_sched {
/* options for timehist command */
bool summary;
bool summary_only;
+ bool idle_hist;
bool show_callchain;
unsigned int max_stack;
bool show_cpu_visual;
@@ -2099,6 +2100,29 @@ static struct thread *get_idle_thread(int cpu)
return idle_threads[cpu];
}
+static void save_idle_callchain(struct thread *thread,
+ struct perf_sample *sample)
+{
+ struct thread *idle;
+ struct idle_thread_runtime *itr;
+
+ if (!symbol_conf.use_callchain || sample->callchain == NULL)
+ return;
+
+ idle = get_idle_thread(sample->cpu);
+ if (idle == NULL) {
+ pr_err("Failed to get idle thread for cpu %d.\n", sample->cpu);
+ return;
+ }
+
+ itr = thread__priv(idle);
+ if (itr == NULL)
+ return;
+
+ itr->last_thread = thread;
+ callchain_cursor__copy(&itr->cursor, &callchain_cursor);
+}
+
/*
* handle runtime stats saved per thread
*/
@@ -2152,6 +2176,11 @@ static struct thread *timehist_get_thread(struct perf_sched *sched,
}
save_task_callchain(sched, sample, evsel, machine);
+ if (sched->idle_hist) {
+ /* copy task callchain when entering to idle */
+ if (perf_evsel__intval(evsel, sample, "next_pid") == 0)
+ save_idle_callchain(thread, sample);
+ }
}
return thread;
--
2.10.1
next prev parent reply other threads:[~2016-12-06 3:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 3:40 [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1) Namhyung Kim
2016-12-06 3:40 ` [PATCH 01/10] perf sched: Cleanup option processing Namhyung Kim
2016-12-06 3:58 ` David Ahern
2016-12-07 18:24 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 02/10] perf tools: Introduce callchain_cursor__copy() Namhyung Kim
2016-12-07 18:25 ` [tip:perf/core] perf callchain: " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 03/10] perf sched timehist: Handle zero sample->tid properly Namhyung Kim
2016-12-06 3:52 ` David Ahern
2016-12-06 3:59 ` Namhyung Kim
2016-12-06 4:01 ` David Ahern
2016-12-07 2:06 ` Namhyung Kim
2016-12-08 14:19 ` Namhyung Kim
2016-12-07 18:25 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 04/10] perf sched timehist: Split is_idle_sample() Namhyung Kim
2016-12-06 3:57 ` David Ahern
2016-12-07 1:26 ` Namhyung Kim
2016-12-06 3:40 ` [PATCH 05/10] perf sched timehist: Cleanup idle_max_cpu handling Namhyung Kim
2016-12-06 4:00 ` David Ahern
2016-12-07 18:26 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 06/10] perf sched timehist: Introduce struct idle_time_data Namhyung Kim
2016-12-06 4:07 ` David Ahern
2016-12-07 2:12 ` Namhyung Kim
2016-12-06 3:40 ` Namhyung Kim [this message]
2016-12-06 3:40 ` [PATCH 08/10] perf sched timehist: Skip non-idle events when necessary Namhyung Kim
2016-12-06 3:40 ` [PATCH 09/10] perf sched timehist: Add -I/--idle-hist option Namhyung Kim
2016-12-06 3:40 ` [PATCH 10/10] perf sched timehist: Show callchains for idle stat Namhyung Kim
2016-12-06 19:44 ` [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1) Arnaldo Carvalho de Melo
2016-12-06 21:31 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206034010.6499-8-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).