From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752781AbcLFLge (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Dec 2016 06:36:34 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:38478 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751636AbcLFLgc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Dec 2016 06:36:32 -0500
Date: Tue, 6 Dec 2016 12:13:19 +0100
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Thomas Casey <tqcasey@gmail.com>
Cc: tglx@linutronix.de, anna-maria@linutronix.de, peterz@infradead.org,
        linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix style issues in kernel/cpu.c
Message-ID: <20161206111319.bdzj3lawxyeyg34l@linutronix.de>
References: <20161203010958.GA910@loonix.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20161203010958.GA910@loonix.localdomain>
User-Agent: NeoMutt/20161126 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016-12-03 01:09:58 [+0000], Thomas Casey wrote:
> This patch fixes style issues in kernel/cpu.c such as wrapping an 80
> character line, calling EXPORT_SYMBOL() immediately after a function is
> defined, and whitespace and spacing issues.
> 
> Signed-off-by: Thomas Casey <tqcasey@gmail.com>

This is okay for most of it.

> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -353,6 +354,7 @@ EXPORT_SYMBOL_GPL(cpu_hotplug_enable);
>  int register_cpu_notifier(struct notifier_block *nb)
>  {
>  	int ret;
> +
>  	cpu_maps_update_begin();
>  	ret = raw_notifier_chain_register(&cpu_chain, nb);
>  	cpu_maps_update_done();
> @@ -363,6 +365,7 @@ int __register_cpu_notifier(struct notifier_block *nb)
>  {
>  	return raw_notifier_chain_register(&cpu_chain, nb);
>  }
> +EXPORT_SYMBOL(__register_cpu_notifier);
>  
>  static int __cpu_notify(unsigned long val, unsigned int cpu, int nr_to_call,
>  			int *nr_calls)
> @@ -661,7 +664,6 @@ void __init cpuhp_threads_init(void)
>  
>  #ifdef CONFIG_HOTPLUG_CPU
>  EXPORT_SYMBOL(register_cpu_notifier);
> -EXPORT_SYMBOL(__register_cpu_notifier);
>  void unregister_cpu_notifier(struct notifier_block *nb)
>  {
>  	cpu_maps_update_begin();

I have a patch posted which gets rid of register_cpu_notifier() and
__register_cpu_notifier() so there is probably no point in fixing /
changing those.

Sebastian