From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933860AbcLGXlh (ORCPT ); Wed, 7 Dec 2016 18:41:37 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:42430 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933649AbcLGXlf (ORCPT ); Wed, 7 Dec 2016 18:41:35 -0500 Date: Wed, 07 Dec 2016 18:41:11 -0500 (EST) Message-Id: <20161207.184111.1365236213357532881.davem@davemloft.net> To: pavel@ucw.cz Cc: LinoSanfilippo@gmx.de, bh74.an@samsung.com, ks.giri@samsung.com, vipul.pandya@samsung.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/2] net: ethernet: stmmac: remove private tx queue lock From: David Miller In-Reply-To: <20161207213757.GC2250@amd> References: <1481141138-19466-1-git-send-email-LinoSanfilippo@gmx.de> <1481141138-19466-3-git-send-email-LinoSanfilippo@gmx.de> <20161207213757.GC2250@amd> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 07 Dec 2016 14:41:54 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Machek Date: Wed, 7 Dec 2016 22:37:57 +0100 > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 982c952..7415bc2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1308,7 +1308,7 @@ static void stmmac_tx_clean(struct stmmac_priv *priv) > unsigned int bytes_compl = 0, pkts_compl = 0; > unsigned int entry = priv->dirty_tx; > > - spin_lock(&priv->tx_lock); > + netif_tx_lock_bh(priv->dev); > > priv->xstats.tx_clean++; > stmmac_tx_clean() runs from either the timer or the NAPI poll handler, both execute from software interrupts, therefore _bh() should be unnecessary.