From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752079AbcLGB5f (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Dec 2016 20:57:35 -0500
Received: from LGEAMRELO11.lge.com ([156.147.23.51]:46934 "EHLO
        lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751611AbcLGB5e (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Dec 2016 20:57:34 -0500
X-Original-SENDERIP: 156.147.1.126
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 10.177.227.17
X-Original-MAILFROM: namhyung@kernel.org
Date: Wed, 7 Dec 2016 10:26:44 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Andi Kleen <andi@firstfloor.org>, Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH 04/10] perf sched timehist: Split is_idle_sample()
Message-ID: <20161207012644.GA17879@sejong>
References: <20161206034010.6499-1-namhyung@kernel.org>
 <20161206034010.6499-5-namhyung@kernel.org>
 <06f40aab-8f66-e727-3a37-3f2657f6bba6@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <06f40aab-8f66-e727-3a37-3f2657f6bba6@gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On Mon, Dec 05, 2016 at 07:57:43PM -0800, David Ahern wrote:
> On 12/5/16 7:40 PM, Namhyung Kim wrote:
> > The is_idle_sample() function actually does more than determining
> > whether sample come from idle task.  Split the callchain part into
> > save_task_callchain() to make it clearer.  Also checking prev_pid from
> > trace data looks unnecessary since it should be always same as
> > sample->pid.
> 
> The timehist command is 3-4 years old now, and over that time it has
> been used on a variety of OS'es -- RHEL6, WRL5, WRL6, various Fedora
> and debian releases, etc. 
> 
> The idle_sample checks were added for a reason. Given the range of
> kernels that have sched tracepoints I'd be wary of just removing it
> regardless of how silly it seems against top of tree kernels.

Hmm.. ok.  Maybe I need to add a comment.

What do you think about moving callchain part then?

Thanks,
Namhyung