From: Krzysztof Kozlowski <krzk@kernel.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h
Date: Wed, 7 Dec 2016 19:55:02 +0200 [thread overview]
Message-ID: <20161207175502.GA13187@kozik-lap> (raw)
In-Reply-To: <1481096342-19104-1-git-send-email-fabf@skynet.be>
On Wed, Dec 07, 2016 at 08:39:02AM +0100, Fabian Frederick wrote:
> Fix the following build errors
I couldn't reproduce it on default config. Can you mention the necessary
environment/defconfig/arch etc.?
Patch itself looks needed. However shouldn't the driver depend also on
GPIOLIB?
Best regards,
Krzysztof
> sound/soc/samsung/tm2_wm5110.c:220:3: error: implicit declaration
> of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
> sound/soc/samsung/tm2_wm5110.c:438:24: error: implicit declaration
> of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> sound/soc/samsung/tm2_wm5110.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
> index 5cdf7d1..24cc9d6 100644
> --- a/sound/soc/samsung/tm2_wm5110.c
> +++ b/sound/soc/samsung/tm2_wm5110.c
> @@ -12,6 +12,7 @@
>
> #include <linux/clk.h>
> #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <sound/pcm_params.h>
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-12-07 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 7:39 [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h Fabian Frederick
2016-12-07 17:55 ` Krzysztof Kozlowski [this message]
2016-12-07 20:31 ` Fabian Frederick
2016-12-08 17:39 ` Krzysztof Kozlowski
2016-12-15 12:21 ` Applied "ASoC: samsung: include gpio consumer.h" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207175502.GA13187@kozik-lap \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).