From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753714AbcLGToq (ORCPT ); Wed, 7 Dec 2016 14:44:46 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:34754 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752148AbcLGTok (ORCPT ); Wed, 7 Dec 2016 14:44:40 -0500 Date: Wed, 7 Dec 2016 20:43:32 +0100 From: Richard Cochran To: Andrei Pistirica Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, davem@davemloft.net, nicolas.ferre@atmel.com, harinikatakamlinux@gmail.com, harini.katakam@xilinx.com, punnaia@xilinx.com, michals@xilinx.com, anirudh@xilinx.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, tbultel@pixelsurmer.com, rafalo@cadence.com Subject: Re: [RFC PATCH net-next v3 2/2] macb: Enable 1588 support in SAMA5Dx platforms. Message-ID: <20161207194332.GB13062@netboy> References: <1481134912-2243-1-git-send-email-andrei.pistirica@microchip.com> <1481134912-2243-2-git-send-email-andrei.pistirica@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481134912-2243-2-git-send-email-andrei.pistirica@microchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2016 at 08:21:52PM +0200, Andrei Pistirica wrote: > +static int gem_hwtst_set(struct net_device *netdev, > + struct ifreq *ifr, int cmd) > +{ ... > + switch (config.rx_filter) { > + case HWTSTAMP_FILTER_NONE: > + if (priv->hwts_rx_en) > + priv->hwts_rx_en = 0; > + break; > + case HWTSTAMP_FILTER_PTP_V1_L4_EVENT: > + case HWTSTAMP_FILTER_PTP_V2_L4_EVENT: > + case HWTSTAMP_FILTER_PTP_V2_L2_EVENT: > + case HWTSTAMP_FILTER_ALL: > + case HWTSTAMP_FILTER_PTP_V1_L4_SYNC: > + case HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ: > + case HWTSTAMP_FILTER_PTP_V2_L2_SYNC: > + case HWTSTAMP_FILTER_PTP_V2_L4_SYNC: > + case HWTSTAMP_FILTER_PTP_V2_L2_DELAY_REQ: > + case HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ: > + case HWTSTAMP_FILTER_PTP_V2_EVENT: > + case HWTSTAMP_FILTER_PTP_V2_SYNC: > + case HWTSTAMP_FILTER_PTP_V2_DELAY_REQ: > + config.rx_filter = HWTSTAMP_FILTER_ALL; Does the device really time stamp all packets? Or did you mean "all PTP packets? For that, use HWTSTAMP_FILTER_PTP_V2_EVENT. Thanks, Richard