From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933417AbcLGWzU (ORCPT ); Wed, 7 Dec 2016 17:55:20 -0500 Received: from mga09.intel.com ([134.134.136.24]:54284 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932583AbcLGWzT (ORCPT ); Wed, 7 Dec 2016 17:55:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,316,1477983600"; d="scan'208";a="40132469" Date: Wed, 7 Dec 2016 18:05:16 -0500 From: Keith Busch To: Dan Streetman Cc: Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel , Dan Streetman Subject: Re: [PATCH] nvme: use the correct msix vector for each queue Message-ID: <20161207230516.GB25959@localhost.localdomain> References: <20161207220348.8572-1-ddstreet@ieee.org> <20161207224414.GE22478@localhost.localdomain> <20161207224941.GA25959@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2016 at 05:46:34PM -0500, Dan Streetman wrote: > > Is there a reason you want to share the interrupt between the queues? The admin queue is hardly ever used (if at all) compared to an IO queue's usage, so why waste the resource? I bet you can't measure a preformance difference on queues that don't share, and it's reasonable to expect an nvme controller's MSI-x count matches the IO queue count, which forces us to share a vector.