From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753159AbcLGOeh (ORCPT ); Wed, 7 Dec 2016 09:34:37 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:58912 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbcLGOef (ORCPT ); Wed, 7 Dec 2016 09:34:35 -0500 To: bigeasy@linutronix.de Cc: tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org Subject: Re: [PATCH] tracing/rb: init the CPU mask on allocation From: Tetsuo Handa References: <20161126231350.10321-7-bigeasy@linutronix.de> <4ec6aa1b-ce6d-259b-c1b1-7ce40d920b17@I-love.SAKURA.ne.jp> <20161207133133.hzkcqfllxcdi3joz@linutronix.de> In-Reply-To: <20161207133133.hzkcqfllxcdi3joz@linutronix.de> Message-Id: <201612072333.HCI81230.OOFQHJtOVFSFLM@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Wed, 7 Dec 2016 23:33:34 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian Andrzej Siewior wrote: > Before commit b32614c03413 ("tracing/rb: Convert to hotplug state > machine") the allocated cpumask was initialized to the mask of ONLINE or > POSSIBLE CPUs. After the CPU hotplug changes the buffer initialisation > moved to trace_rb_cpu_prepare() but I forgot to initially set the > cpumask to zero. This is done now. > > Fixes: b32614c03413 ("tracing/rb: Convert to hotplug state machine") > Reported-by: Tetsuo Handa > Signed-off-by: Sebastian Andrzej Siewior The system can boot now. Thank you. Tested-by: Tetsuo Handa > --- > kernel/trace/ring_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > index 67da107e5712..a85739efcc30 100644 > --- a/kernel/trace/ring_buffer.c > +++ b/kernel/trace/ring_buffer.c > @@ -1297,7 +1297,7 @@ struct ring_buffer *__ring_buffer_alloc(unsigned long size, unsigned flags, > if (!buffer) > return NULL; > > - if (!alloc_cpumask_var(&buffer->cpumask, GFP_KERNEL)) > + if (!zalloc_cpumask_var(&buffer->cpumask, GFP_KERNEL)) > goto fail_free_buffer; > > nr_pages = DIV_ROUND_UP(size, BUF_PAGE_SIZE); > -- > 2.11.0