From: Vinod Koul <vinod.koul@intel.com>
To: Kirtika Ruchandani <kirtika@chromium.org>
Cc: tiwai@suse.com, arnd@arndb.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
Hardik T Shah <hardik.t.shah@intel.com>,
Omair M Abdullah <omair.m.abdullah@intel.com>,
Jeeja KP <jeeja.kp@intel.com>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable
Date: Thu, 8 Dec 2016 15:30:01 +0530 [thread overview]
Message-ID: <20161208095959.GY6408@localhost> (raw)
In-Reply-To: <1481176902-131803-1-git-send-email-kirtika@chromium.org>
On Wed, Dec 07, 2016 at 10:01:42PM -0800, Kirtika Ruchandani wrote:
> Commit 4cd9899f0d16 introduced struct skl_module_fmt* out_fmt without
> using it. Compiling with W=1 gives the below warning, fix it.
>
> sound/soc/intel/skylake/skl-topology.c: In function ‘skl_tplg_update_buffer_size’:
> sound/soc/intel/skylake/skl-topology.c:301:34: warning: variable ‘out_fmt’ set but not used [-Wunused-but-set-variable]
>
> This is a harmless warning and is only being fixed to reduce the noise
> with W=1 in the kernel.
Heya,
Can you please tell me which tree this warning was found on? At least this
doesn't exist upstream. The out_fmt is very well used.
If you saw this in Chromium tree then it might be due to some missing
backports..
> diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
> index bd313c9..4352236a 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -298,7 +298,7 @@ static void skl_tplg_update_buffer_size(struct skl_sst *ctx,
> struct skl_module_cfg *mcfg)
> {
> int multiplier = 1;
> - struct skl_module_fmt *in_fmt, *out_fmt;
> + struct skl_module_fmt *in_fmt;
> int in_rate, out_rate;
>
>
> @@ -306,7 +306,6 @@ static void skl_tplg_update_buffer_size(struct skl_sst *ctx,
> * change for pin 0 only
> */
> in_fmt = &mcfg->in_fmt[0];
> - out_fmt = &mcfg->out_fmt[0];
>
> if (mcfg->m_type == SKL_MODULE_TYPE_SRCINT)
> multiplier = 5;
> --
> 2.8.0.rc3.226.g39d4020
--
~Vinod
next prev parent reply other threads:[~2016-12-08 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 6:01 [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable Kirtika Ruchandani
2016-12-08 10:00 ` Vinod Koul [this message]
2016-12-08 10:18 ` Vinod Koul
2016-12-08 16:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208095959.GY6408@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=hardik.t.shah@intel.com \
--cc=jeeja.kp@intel.com \
--cc=kirtika@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omair.m.abdullah@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).