From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932276AbcLHLS0 (ORCPT ); Thu, 8 Dec 2016 06:18:26 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:60614 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbcLHLSY (ORCPT ); Thu, 8 Dec 2016 06:18:24 -0500 From: Colin King To: Iyappan Subramanian , Keyur Chudgar , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] drivers: net: xgene: initialize slots Date: Thu, 8 Dec 2016 11:17:54 +0000 Message-Id: <20161208111754.9711-1-colin.king@canonical.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King static analysis using cppcheck detected that slots was uninitialized. Fix this by initializing it to buf_pool->slots - 1 Found using static analysis with CoverityScan, CID #1387620 Fixes: a9380b0f7be818 ("drivers: net: xgene: Add support for Jumbo frame") Signed-off-by: Colin Ian King --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 6c7eea8..899163c 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -636,6 +636,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool, dev = ndev_to_dev(buf_pool->ndev); head = buf_pool->head; + slots = buf_pool->slots - 1; for (i = 0; i < 4; i++) { frag_size = xgene_enet_get_data_len(le64_to_cpu(desc[i ^ 1])); -- 2.10.2