From: Peter Zijlstra <peterz@infradead.org>
To: Pan Xinhui <xinhui@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Peter Anvin <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Chris Wright <chrisw@sous-sol.org>,
Alok Kataria <akataria@vmware.com>,
Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kernel test robot <xiaolong.ye@intel.com>
Subject: Re: [PATCH 2/2] x86, paravirt: Fix bool return type for PVOP_CALL
Date: Thu, 8 Dec 2016 17:50:13 +0100 [thread overview]
Message-ID: <20161208165013.GM3107@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <474f05c8-8bca-f68f-6499-ce7b424ff984@linux.vnet.ibm.com>
On Fri, Dec 09, 2016 at 12:40:35AM +0800, Pan Xinhui wrote:
>
> hi, Peter
> I think I know the point.
>
> then could we just let __eax rettype(here is bool), not unsigned long?
> I does not do tests for my thoughts.
>
> @@ -461,7 +461,9 @@ int paravirt_disable_iospace(void);
> #define PVOP_VCALL_ARGS \
> unsigned long __eax = __eax, __edx = __edx, __ecx = __ecx; \
> register void *__sp asm("esp")
> -#define PVOP_CALL_ARGS PVOP_VCALL_ARGS
> +#define PVOP_CALL_ARGS \
> + rettype __eax = __eax, __edx = __edx, __ecx = __ecx; \
> + register void *__sp asm("esp")
Doesn't work on i386 where eax is also an argument register.
next prev parent reply other threads:[~2016-12-08 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 15:42 [PATCH 0/2] Fix paravirt fail Peter Zijlstra
2016-12-08 15:42 ` [PATCH 1/2] x86,paravirt: Fix native_patch() Peter Zijlstra
2016-12-12 6:49 ` [tip:locking/core] x86/paravirt: " tip-bot for Peter Zijlstra
2016-12-08 15:42 ` [PATCH 2/2] x86, paravirt: Fix bool return type for PVOP_CALL Peter Zijlstra
2016-12-08 16:40 ` Pan Xinhui
2016-12-08 16:50 ` Peter Zijlstra [this message]
2016-12-12 6:50 ` [tip:locking/core] x86/paravirt: Fix bool return type for PVOP_CALL() tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208165013.GM3107@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akataria@vmware.com \
--cc=bp@alien8.de \
--cc=chrisw@sous-sol.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xiaolong.ye@intel.com \
--cc=xinhui.pan@linux.vnet.ibm.com \
--cc=xinhui@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).