From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753772AbcLIHQn (ORCPT ); Fri, 9 Dec 2016 02:16:43 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44848 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752843AbcLIHQm (ORCPT ); Fri, 9 Dec 2016 02:16:42 -0500 Date: Fri, 9 Dec 2016 08:16:49 +0100 From: Greg Kroah-Hartman To: manju goudar Cc: Alan Stern , USB list , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] USB: OHCI: pxa27x:fix warnings and error Message-ID: <20161209071649.GA29639@kroah.com> References: <1480976338-15646-1-git-send-email-csmanjuvijay@gmail.com> <1481153865-20554-1-git-send-email-csmanjuvijay@gmail.com> <20161208164951.GA14515@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 08, 2016 at 10:30:35PM +0000, manju goudar wrote: > > > On Thu, Dec 8, 2016 at 4:49 PM, Greg Kroah-Hartman > wrote: > > On Wed, Dec 07, 2016 at 11:37:45PM +0000, csmanjuvijay@gmail.com wrote: > > From: Manjunath Goudar > > > > This patch will fix the checkpatch.pl following warnings and error: > > WARNING: Block comments use * on subsequent lines > > WARNING: Block comments use a trailing */ on a separate line > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, > > ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ... > > ERROR: space prohibited after that open parenthesis '(' > > > > Signed-off-by: Manjunath Goudar > > Cc: Alan Stern > > Cc: Greg Kroah-Hartman > > Cc: linux-usb@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > --- > > changelog V1->V2: > > Warnings and error message is added to the patch discrition. > > > >  drivers/usb/host/ohci-pxa27x.c | 24 +++++++++++------------- > >  1 file changed, 11 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci- > pxa27x.c > > index 79efde8f..73445ab 100644 > > --- a/drivers/usb/host/ohci-pxa27x.c > > +++ b/drivers/usb/host/ohci-pxa27x.c > > @@ -106,7 +106,8 @@ > >  #define UHCHIE_UPS2IE        (1 << 12)       /* Power Sense Port2 IntEn > */ > >  #define UHCHIE_UPS1IE        (1 << 11)       /* Power Sense Port1 IntEn > */ > >  #define UHCHIE_TAIE  (1 << 10)       /* HCI Interface Transfer Abort > > -                                        Interrupt Enable*/ > > +                                      * Interrupt Enable > > +                                      */ > >  #define UHCHIE_HBAIE (1 << 8)        /* HCI Buffer Active IntEn */ > >  #define UHCHIE_RWIE  (1 << 7)        /* Remote Wake-up IntEn */ > > > > @@ -128,14 +129,14 @@ struct pxa27x_ohci { > >  #define to_pxa27x_ohci(hcd)  (struct pxa27x_ohci *)(hcd_to_ohci(hcd)-> > priv) > > > >  /* > > -  PMM_NPS_MODE -- PMM Non-power switching mode > > -      Ports are powered continuously. > > - > > -  PMM_GLOBAL_MODE -- PMM global switching mode > > -      All ports are powered at the same time. > > - > > -  PMM_PERPORT_MODE -- PMM per port switching mode > > -      Ports are powered individually. > > + * PMM_NPS_MODE -- PMM Non-power switching mode > > + *     Ports are powered continuously. > > + * > > + * PMM_GLOBAL_MODE -- PMM global switching mode > > + *     All ports are powered at the same time. > > + * > > + * PMM_PERPORT_MODE -- PMM per port switching mode > > + *     Ports are powered individually. > >   */ > >  static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int > mode) > >  { > > @@ -157,10 +158,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci > *pxa_ohci, int mode) > >               uhcrhdb |= (0x7<<17); > >               break; > >       default: > > -             printk( KERN_ERR > > -                     "Invalid mode %d, set to non-power switch mode.\n", > > -                     mode ); > > - > > +             dev_err(mode, "Invalid mode %d,set to non-power switch > mode.\n"); > > Did you even compile this code? > > > Yes It is successful compiled.  I don't believe you. Look at your change here and tell me how that dev_err() function is correct. > Please do so... > > And don't mix different types of fixes in the same patch please. > > don't mix up means each type of warning fix as a separate patch?   Yes please. thanks, greg k-h