From: Pavel Machek <pavel@ucw.cz>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
bh74.an@samsung.com, ks.giri@samsung.com,
vipul.pandya@samsung.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock
Date: Fri, 9 Dec 2016 12:21:42 +0100 [thread overview]
Message-ID: <20161209112142.GA22710@amd> (raw)
In-Reply-To: <20161208231943.GA13102@electric-eye.fr.zoreil.com>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Fri 2016-12-09 00:19:43, Francois Romieu wrote:
> Lino Sanfilippo <LinoSanfilippo@gmx.de> :
> [...]
> > OTOH Pavel said that he actually could produce a deadlock. Now I wonder if
> > this is caused by that locking scheme (in a way I have not figured out yet)
> > or if it is a different issue.
>
> stmmac_tx_err races with stmmac_xmit.
Umm, yes, that looks real.
And that means that removing tx_lock will not be completely trivial
:-(. Lino, any ideas there?
netif_tx_lock_irqsave() would help, but afaict that one does not
exist.
Plus, does someone know how to trigger the status == tx_hard_error? I
tried powering down the switch, but that did not do it.
Thanks, Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-12-09 11:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 20:05 Remove private locks to avoid possible deadlock Lino Sanfilippo
2016-12-07 20:05 ` [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock Lino Sanfilippo
2016-12-07 23:15 ` Francois Romieu
2016-12-08 20:32 ` Lino Sanfilippo
2016-12-08 21:54 ` Pavel Machek
2016-12-08 22:12 ` Lino Sanfilippo
2016-12-08 22:18 ` Pavel Machek
2016-12-08 22:45 ` Lino Sanfilippo
2016-12-08 23:19 ` Francois Romieu
2016-12-09 11:21 ` Pavel Machek [this message]
2016-12-10 2:25 ` Lino Sanfilippo
2016-12-11 20:11 ` Pavel Machek
2016-12-15 19:27 ` Lino Sanfilippo
2016-12-15 21:03 ` Pavel Machek
2016-12-15 21:32 ` Lino Sanfilippo
2016-12-15 22:33 ` Lino Sanfilippo
2016-12-17 17:31 ` Pavel Machek
2016-12-18 0:15 ` Francois Romieu
2016-12-18 16:15 ` Lino Sanfilippo
2016-12-18 17:23 ` Pavel Machek
2016-12-18 18:30 ` Pavel Machek
2016-12-19 22:49 ` Lino Sanfilippo
2016-12-18 20:16 ` Pavel Machek
2016-12-19 10:02 ` Pavel Machek
2016-12-20 0:05 ` Francois Romieu
2016-12-07 20:05 ` [PATCH 2/2] net: ethernet: stmmac: " Lino Sanfilippo
2016-12-07 20:55 ` Pavel Machek
2016-12-07 20:59 ` Pavel Machek
2016-12-07 21:37 ` Pavel Machek
2016-12-07 21:43 ` Lino Sanfilippo
2016-12-07 22:34 ` Lino Sanfilippo
2016-12-07 23:21 ` Pavel Machek
2016-12-07 23:41 ` David Miller
2016-12-08 14:08 ` Pavel Machek
2016-12-08 15:26 ` David Miller
2016-12-08 15:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209112142.GA22710@amd \
--to=pavel@ucw.cz \
--cc=LinoSanfilippo@gmx.de \
--cc=alexandre.torgue@st.com \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=ks.giri@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=romieu@fr.zoreil.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).