From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753407AbcLKHMd (ORCPT ); Sun, 11 Dec 2016 02:12:33 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49842 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbcLKHMc (ORCPT ); Sun, 11 Dec 2016 02:12:32 -0500 Date: Sun, 11 Dec 2016 08:12:34 +0100 From: Greg Kroah-Hartman To: Herbert Xu Cc: linux-serial@vger.kernel.org, Linux Kernel Mailing List , Matthew Leach Subject: Re: [PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags" Message-ID: <20161211071234.GC32092@kroah.com> References: <20161211020549.GA1321@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161211020549.GA1321@gondor.apana.org.au> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 11, 2016 at 10:05:49AM +0800, Herbert Xu wrote: > This commit needs to be reverted because it prevents people from > using the serial console as a secondary console with input being > directed to tty0. > > IOW, if you boot with console=ttyS0 console=tty0 then all kernels > prior to this commit will produce output on both ttyS0 and tty0 > but input will only be taken from tty0. With this patch the serial > console will always be the primary console instead of tty0, > potentially preventing people from getting into their machines in > emergency situations. > > Fixes: d03516df8375 ("tty: serial: 8250: add CON_CONSDEV to flags") > Signed-off-by: Herbert Xu > > diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c > index 240a361..e8819aa 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -675,7 +675,7 @@ static int univ8250_console_match(struct console *co, char *name, int idx, > .device = uart_console_device, > .setup = univ8250_console_setup, > .match = univ8250_console_match, > - .flags = CON_PRINTBUFFER | CON_ANYTIME | CON_CONSDEV, > + .flags = CON_PRINTBUFFER | CON_ANYTIME, > .index = -1, > .data = &serial8250_reg, > }; Ok, this is the second time this has been reported. Matthew seems to be ignoring my email about this, so I guess I'll just revert the patch, as it's obviously causing problems... thanks, greg k-h