From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013AbcLLCcT (ORCPT ); Sun, 11 Dec 2016 21:32:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55834 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbcLLCcS (ORCPT ); Sun, 11 Dec 2016 21:32:18 -0500 Date: Mon, 12 Dec 2016 10:32:14 +0800 From: Baoquan He To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com, mingo@redhat.com, x86@kernel.org, keescook@chromium.org, yinghai@kernel.org, thgarnie@google.com, kuleshovmail@gmail.com, luto@kernel.org, mcgrof@kernel.org, anderson@redhat.com, dyoung@redhat.com, xlpang@redhat.com Subject: Re: [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime Message-ID: <20161212023214.GH1034@x1> References: <1481294518-29595-1-git-send-email-bhe@redhat.com> <1481294518-29595-3-git-send-email-bhe@redhat.com> <20161210103151.56d7k2iwwwu5acmw@pd.tnic> <20161210122757.GE1034@x1> <20161210123340.begeyyiegktangh2@pd.tnic> <20161210134156.GF1034@x1> <20161210162805.sdpidajk47mgquds@pd.tnic> <20161211105829.GG1034@x1> <20161211120621.fu5dzvadhmowj4ui@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161211120621.fu5dzvadhmowj4ui@pd.tnic> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 12 Dec 2016 02:32:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/16 at 01:06pm, Borislav Petkov wrote: > On Sun, Dec 11, 2016 at 06:58:29PM +0800, Baoquan He wrote: > > For arguing and defending myself, I couldn't be very objective. > > Yeah, it is mind-boggling the amount of bullshit you would come up with > instead of simply saying, "no, I don't have a good reason and use case > for my patch". It made me laugh, FWIW. Especially the bit about people > getting naked - I had to go check we're still talking about the same > thing. Yes, I can't agree more, that use case is totally of bullshit. At the very beginning, we all know that this patch is trying to fix the inconsistency between kaslr codes not compiled in and code compiled in but with "nokaslr" specified. In short, this patch is fixing an inconsistency, no bug is reported yet. Here the inconsistency is the reason for this patch. I think it has been made very clearly now. This also has been pointed out by Kees when he offered his "Acked-by". I welcome and treat all comments seriously, no other choices are given to me. If at the start, you said straightforwardly like: "No bug, no fix!" "A little inconsistency makes the world more exciting, it can make me high." or "We can leave with it until a bug is reported, remaining 1G is no harm." I can accept it totally and mute. But I didn't hear them. As an expert of x86 arch and authority, you honor me to step in and give comments, I have to reply with respect. I am very glad to see you said you laughed at something, whatever it is for, at least it means thing is not screwed up thoroughly, laughter is always good. Thanks Baoquan