From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754083AbcLLJe2 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Dec 2016 04:34:28 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:33446 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751266AbcLLJe1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Dec 2016 04:34:27 -0500
Date: Mon, 12 Dec 2016 12:33:52 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
        James Smart <james.smart@broadcom.com>,
        Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [patch] nvme-fabrics: correct some printk information
Message-ID: <20161212093352.GB8176@mwanda>
References: <20161210090618.GA11680@elgon.mountain>
 <1481369270.5946.51.camel@perches.com>
 <20161210184029.GY8176@mwanda>
 <alpine.DEB.2.20.1612102104050.1986@hadrien>
 <1481403290.1764.1.camel@perches.com>
 <20161210210737.GR8244@mwanda>
 <1481408662.1764.3.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1481408662.1764.3.camel@perches.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:
> On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> > > --- drivers//dma/pxa_dma.c
> > > +++ /tmp/nothing//dma/pxa_dma.c
> > > @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc
> > >  	dcsr = phy_readl_relaxed(phy, DCSR);
> > >  	phy_writel(phy, dcsr, DCSR);
> > >  	if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan))
> > > -		dev_warn(&phy->vchan->vc.chan.dev->device,
> > > -			 "%s(chan=%p): PXA_DCSR_BUSERR\n",
> > > -			 __func__, &phy->vchan);
> > 
> > That's not a defect.  We're getting the address of vchan.  I don't get
> > it?
> 
> $ git grep -n -w vchan drivers/dma/pxa*
> drivers/dma/pxa_dma.c:103:      struct pxad_chan        *vchan;

I'm not sure what you're saying here still.  This code works as
intended.  We're not printing a stack address.

regards,
dan carpenter