From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Doug Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Caesar Wang <wxt@rock-chips.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support
Date: Mon, 12 Dec 2016 11:01:10 +0100 [thread overview]
Message-ID: <20161212100110.GA13907@mail.corp.redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1612120951130.16984@cbobk.fhfr.pm>
On Dec 12 2016 or thereabouts, Jiri Kosina wrote:
> Given the timing (merge window being open) and given then NACK given by
> Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now
> obsolete, and has been superseded by for-4.10/i2c-hid-nopower).
>
> However, this is mostly done in order to provide more time for discussion;
> I still disagree with the reasoning behind the NACK.
>
To hopefully make things going forward a little bit, I was wondering
over the week-end if we should not solve this particular issue by adding
an intermediate platform DT node:
instead of having:
---
i2c-hid-dev@2c {
compatible = "hid-over-i2c";
reg = <0x2c>;
hid-descr-addr = <0x0020>;
interrupt-parent = <&gpx3>;
interrupts = <3 2>;
vdd-supply = <sth>;
init-delay-ms = <100>;
};
---
we would have:
---
platform-i2c-hid@01 {
compatible = "very-special-board-that-needs-firmware-quirks-and-delay-of-100ms";
vdd-supply = <sth>;
i2c-hid-dev@2c {
compatible = "hid-over-i2c";
reg = <0x2c>;
hid-descr-addr = <0x0020>;
interrupt-parent = <&gpx3>;
interrupts = <3 2>;
};
};
---
If I am not wrong, the platform device should be initialized before
i2c-hid get called, which allows to setup properly the vdd supply.
On resume/suspend, the tree should be respected and we should be able to
enable/disable power in the same fashion this patch provides.
We could then extend this platform device at will without tinkering in
i2c-hid and we could also handle the GPIOs, reset or whatever is
required in the future through compatibles.
Thoughts? yes? no? bullshit?
Cheers,
Benjamin
next prev parent reply other threads:[~2016-12-12 10:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 1:21 [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Brian Norris
2016-12-01 1:21 ` [PATCH v2 2/2] HID: i2c-hid: support Wacom digitizer + regulator Brian Norris
2016-12-01 14:41 ` Benjamin Tissoires
2016-12-01 17:30 ` Brian Norris
2016-12-01 14:34 ` [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Benjamin Tissoires
2016-12-01 17:24 ` Brian Norris
2016-12-05 23:59 ` Rob Herring
2016-12-06 0:16 ` Dmitry Torokhov
2016-12-06 8:48 ` Benjamin Tissoires
2016-12-06 14:56 ` Rob Herring
2016-12-06 16:18 ` Doug Anderson
2016-12-08 15:41 ` Benjamin Tissoires
2016-12-08 16:03 ` Rob Herring
2016-12-08 16:13 ` Dmitry Torokhov
2016-12-08 16:26 ` Rob Herring
2016-12-08 18:12 ` Dmitry Torokhov
2016-12-09 14:36 ` Rob Herring
2016-12-09 14:36 ` Jiri Kosina
2016-12-09 15:01 ` Rob Herring
2016-12-09 16:16 ` Doug Anderson
2016-12-12 8:53 ` Jiri Kosina
2016-12-12 10:01 ` Benjamin Tissoires [this message]
2016-12-12 14:47 ` Rob Herring
2016-12-12 18:34 ` Brian Norris
2016-12-13 22:10 ` Rob Herring
2016-12-08 16:01 ` Rob Herring
2016-12-09 16:05 ` Doug Anderson
2016-12-09 17:44 ` Rob Herring
2016-12-05 23:42 ` Rob Herring
2016-12-05 23:54 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212100110.GA13907@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).