From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbcLLNpK (ORCPT ); Mon, 12 Dec 2016 08:45:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47318 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752729AbcLLNo4 (ORCPT ); Mon, 12 Dec 2016 08:44:56 -0500 Date: Mon, 12 Dec 2016 14:44:52 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , David Ahern , Namhyung Kim , Peter Zijlstra , lkml , Ingo Molnar Subject: Re: [PATCH 1/5] perf mem: Fix --all-user/--all-kernel options Message-ID: <20161212134452.GA25975@krava> References: <1481538943-21874-1-git-send-email-jolsa@kernel.org> <1481538943-21874-2-git-send-email-jolsa@kernel.org> <20161212134311.GA5650@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161212134311.GA5650@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 12 Dec 2016 13:44:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2016 at 10:43:11AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Dec 12, 2016 at 11:35:39AM +0100, Jiri Olsa escreveu: > > Removing extra '--' prefix. > > Please add a Fixes: tag in such cases, as this helps backporters to > figure out what affects packages they published, in this case I'm > adding: > > Fixes: ad16511b0e40 ("perf mem: Add -U/-K (--all-user/--all-kernel) > options") > > And I just added this to the Todo[1] list: > > * Improve git pre-commit hook script to check for OPTION() with -- in > its name, to fix bugs like ad16511b0e40 ("perf mem: Add -U/-K > (--all-user/--all-kernel) options") (acme) > > :-) I forgot ;-) thanks jirka > > Thanks, > > - Arnaldo > > [1] https://perf.wiki.kernel.org/index.php/Todo > > > Signed-off-by: Jiri Olsa > > Cc: David Ahern > > Cc: Namhyung Kim > > Cc: Peter Zijlstra > > Link: http://lkml.kernel.org/n/tip-p8x8lf2ekjpqc2x5ixw61505@git.kernel.org > > --- > > tools/perf/builtin-mem.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c > > index d1ce29be560e..cd7bc4d104e2 100644 > > --- a/tools/perf/builtin-mem.c > > +++ b/tools/perf/builtin-mem.c > > @@ -70,8 +70,8 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem) > > OPT_UINTEGER(0, "ldlat", &perf_mem_events__loads_ldlat, "mem-loads latency"), > > OPT_INCR('v', "verbose", &verbose, > > "be more verbose (show counter open errors, etc)"), > > - OPT_BOOLEAN('U', "--all-user", &all_user, "collect only user level data"), > > - OPT_BOOLEAN('K', "--all-kernel", &all_kernel, "collect only kernel level data"), > > + OPT_BOOLEAN('U', "all-user", &all_user, "collect only user level data"), > > + OPT_BOOLEAN('K', "all-kernel", &all_kernel, "collect only kernel level data"), > > OPT_END() > > }; > > > > -- > > 2.7.4