Hi Jia, [auto build test ERROR on nfsd/nfsd-next] [also build test ERROR on v4.9 next-20161209] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jia-He/lockd-Change-nsm_use_hostnames-from-bool-to-u32/20161212-001614 base: git://linux-nfs.org/~bfields/linux.git nfsd-next config: x86_64-kexec (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): In file included from include/linux/module.h:18:0, from fs/lockd/svc.c:15: >> include/linux/moduleparam.h:146:27: error: expected ')' before '&' token param_check_##type(name, &(value)); \ ^ include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named' module_param_named(name, name, type, perm) ^~~~~~~~~~~~~~~~~~ fs/lockd/svc.c:661:1: note: in expansion of macro 'module_param' module_param(nsm_use_hostnames, u32, 0644); ^~~~~~~~~~~~ >> include/linux/moduleparam.h:147:25: error: 'param_ops_u32' undeclared here (not in a function) module_param_cb(name, ¶m_ops_##type, &value, perm); \ ^ include/linux/moduleparam.h:224:39: note: in definition of macro '__module_param_call' = { __param_str_##name, THIS_MODULE, ops, \ ^~~ include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb' module_param_cb(name, ¶m_ops_##type, &value, perm); \ ^~~~~~~~~~~~~~~ include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named' module_param_named(name, name, type, perm) ^~~~~~~~~~~~~~~~~~ fs/lockd/svc.c:661:1: note: in expansion of macro 'module_param' module_param(nsm_use_hostnames, u32, 0644); ^~~~~~~~~~~~ vim +146 include/linux/moduleparam.h 546970bc Rusty Russell 2010-08-11 140 * 546970bc Rusty Russell 2010-08-11 141 * Usually it's a good idea to have variable names and user-exposed names the 546970bc Rusty Russell 2010-08-11 142 * same, but that's harder if the variable must be non-static or is inside a 546970bc Rusty Russell 2010-08-11 143 * structure. This allows exposure under a different name. 546970bc Rusty Russell 2010-08-11 144 */ 546970bc Rusty Russell 2010-08-11 145 #define module_param_named(name, value, type, perm) \ 546970bc Rusty Russell 2010-08-11 @146 param_check_##type(name, &(value)); \ 546970bc Rusty Russell 2010-08-11 @147 module_param_cb(name, ¶m_ops_##type, &value, perm); \ 546970bc Rusty Russell 2010-08-11 148 __MODULE_PARM_TYPE(name, #type) 546970bc Rusty Russell 2010-08-11 149 546970bc Rusty Russell 2010-08-11 150 /** :::::: The code at line 146 was first introduced by commit :::::: 546970bc6afc7fb37447fbac09b82c7884662c21 param: add kerneldoc to moduleparam.h :::::: TO: Rusty Russell :::::: CC: Rusty Russell --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation