From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934981AbcLMS7V (ORCPT ); Tue, 13 Dec 2016 13:59:21 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34254 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932912AbcLMS7T (ORCPT ); Tue, 13 Dec 2016 13:59:19 -0500 Date: Tue, 13 Dec 2016 12:59:15 -0600 From: Rob Herring To: Sergio Prado Cc: gregkh@linuxfoundation.org, mark.rutland@arm.com, balbi@kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: usb: add DT binding for s3c2410 USB device controller Message-ID: <20161213185915.z2ze7wzx4im5hxdh@rob-hp-laptop> References: <1481310400-28676-1-git-send-email-sergio.prado@e-labworks.com> <1481310400-28676-2-git-send-email-sergio.prado@e-labworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481310400-28676-2-git-send-email-sergio.prado@e-labworks.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 09, 2016 at 05:06:39PM -0200, Sergio Prado wrote: > Adds the device tree bindings description for Samsung S3C2410 and > compatible USB device controller. > > Signed-off-by: Sergio Prado > --- > .../devicetree/bindings/usb/s3c2410-usb.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/s3c2410-usb.txt b/Documentation/devicetree/bindings/usb/s3c2410-usb.txt > index e45b38ce2986..4d3f9894c2d4 100644 > --- a/Documentation/devicetree/bindings/usb/s3c2410-usb.txt > +++ b/Documentation/devicetree/bindings/usb/s3c2410-usb.txt > @@ -20,3 +20,31 @@ usb0: ohci@49000000 { > clocks = <&clocks UCLK>, <&clocks HCLK_USBH>; > clock-names = "usb-bus-host", "usb-host"; > }; > + > +Samsung S3C2410 and compatible USB device controller > + > +Required properties: > + - compatible: Should be one of the following > + "samsung,s3c2410-udc" > + "samsung,s3c2440-udc" > + - reg: address and length of the controller memory mapped region > + - interrupts: interrupt number for the USB device controller > + - clocks: Should reference the bus and host clocks > + - clock-names: Should contain two strings > + "usb-bus-gadget" for the USB bus clock Pretty sure the h/w clock name in the datasheet does not use the Linux term gadget. > + "usb-device" for the USB device clock > + > +Optional properties: > + - samsung,vbus-gpio: If present, specifies a gpio that needs to be > + activated for the bus to be powered. Isn't it the host side that controls Vbus? > + - samsung,pullup-gpio: If present, specifies a gpio to control the Both GPIOs need to specify the active state. > + USB D+ pullup. > + > +usb1: udc@52000000 { > + compatible = "samsung,s3c2440-udc"; > + reg = <0x52000000 0x100000>; > + interrupts = <0 0 25 3>; > + clocks = <&clocks UCLK>, <&clocks HCLK_USBD>; > + clock-names = "usb-bus-gadget", "usb-device"; > + samsung,pullup-gpio = <&gpc 5 GPIO_ACTIVE_HIGH>; > +}; > -- > 1.9.1 >