From: Reza Arbab <arbab@linux.vnet.ibm.com>
To: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
isimatu.yasuaki@jp.fujitsu.com
Subject: Re: [PATCH v2] memory_hotplug: zone_can_shift() returns boolean value
Date: Tue, 13 Dec 2016 17:12:36 -0600 [thread overview]
Message-ID: <20161213231236.g6prnnjy6nyt4qkf@arbab-laptop> (raw)
In-Reply-To: <2f9c3837-33d7-b6e5-59c0-6ca4372b2d84@gmail.com>
On Tue, Dec 13, 2016 at 03:29:49PM -0500, Yasuaki Ishimatsu wrote:
>online_{kernel|movable} is used to change the memory zone to
>ZONE_{NORMAL|MOVABLE} and online the memory.
>
>To check that memory zone can be changed, zone_can_shift() is used.
>Currently the function returns minus integer value, plus integer
>value and 0. When the function returns minus or plus integer value,
>it means that the memory zone can be changed to ZONE_{NORNAL|MOVABLE}.
>
>But when the function returns 0, there is 2 meanings.
>
>One of the meanings is that the memory zone does not need to be changed.
>For example, when memory is in ZONE_NORMAL and onlined by online_kernel
>the memory zone does not need to be changed.
>
>Another meaning is that the memory zone cannot be changed. When memory
>is in ZONE_NORMAL and onlined by online_movable, the memory zone may
>not be changed to ZONE_MOVALBE due to memory online limitation(see
>Documentation/memory-hotplug.txt). In this case, memory must not be
>onlined.
>
>The patch changes the return type of zone_can_shift() so that memory
>is not onlined when memory zone cannot be changed.
Reviewed-by: Reza Arbab <arbab@linux.vnet.ibm.com>
--
Reza Arbab
next prev parent reply other threads:[~2016-12-13 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 20:29 [PATCH v2] memory_hotplug: zone_can_shift() returns boolean value Yasuaki Ishimatsu
2016-12-13 23:12 ` Reza Arbab [this message]
2017-01-09 23:27 ` Andrew Morton
2017-01-11 16:41 ` Yasuaki Ishimatsu
2017-01-11 16:48 ` [PATCH v3] " Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213231236.g6prnnjy6nyt4qkf@arbab-laptop \
--to=arbab@linux.vnet.ibm.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).