From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758395AbcLOOsY (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Dec 2016 09:48:24 -0500
Received: from mail-wj0-f196.google.com ([209.85.210.196]:36645 "EHLO
        mail-wj0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758372AbcLOOsU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Dec 2016 09:48:20 -0500
Date: Thu, 15 Dec 2016 15:48:16 +0100
From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= <kernel@kempniu.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>,
        Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Darren Hart <dvhart@infradead.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Louis Davis <Louis_Davis@dell.com>,
        Jim Dailey <Jim_Dailey@dell.com>, Alex Hung <alex.hung@canonical.com>,
        Hui Wang <hui.wang@canonical.com>, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()
Message-ID: <20161215144816.GC22695@kmp-mobile.hq.kempniu.pl>
References: <20161208123618.28603-1-kernel@kempniu.pl>
 <20161208123618.28603-5-kernel@kempniu.pl>
 <201612111140.48561@pali>
 <CAHp75VfTLrY_MBphzg2idGhQbvnjyf7+9-BQjD37TXnucj+nMw@mail.gmail.com>
 <CAHp75VcTSDOv4JK9Hr=GefWtOeYaQUFxTASwAeFJqM18BuU33w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75VcTSDOv4JK9Hr=GefWtOeYaQUFxTASwAeFJqM18BuU33w@mail.gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Wed, Dec 14, 2016 at 3:54 AM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> >> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote:
> >>> All calls to dell_app_wmi_led_set() have been replaced with direct
> >>> calls to dell_micmute_led_set(), so the former can be safely removed
> >>> along with its related enum.
> >>>
> >>> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
> >>
> >> I would suggest to squash patches 2,3,4 into one. But I let decision to
> >> alsa & led maintainers.
> >
> > I don't like the part where we are exporting something for just one
> > moment.
> 
> Oops, misread function name, though still valid vote for one patch.

Thanks, I will do that in v2 (and thanks to Pali for suggesting it).

-- 
Best regards,
Michał Kępień