* [PATCH] misc: panel: move LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h
@ 2016-12-15 19:43 Corentin Labbe
2017-01-10 17:37 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2016-12-15 19:43 UTC (permalink / raw)
To: willy, ksenija.stanojevic, arnd, gregkh; +Cc: linux-kernel, Corentin Labbe
This patch move the define for LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h.
It's better that all minor number definitions are in the same place.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/misc/panel.c | 3 ---
include/linux/miscdevice.h | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/panel.c b/drivers/misc/panel.c
index 6030ac5..b05c3c7 100644
--- a/drivers/misc/panel.c
+++ b/drivers/misc/panel.c
@@ -61,9 +61,6 @@
#include <linux/io.h>
#include <linux/uaccess.h>
-#define LCD_MINOR 156
-#define KEYPAD_MINOR 185
-
#define PANEL_VERSION "0.9.5"
#define LCD_MAXBYTES 256 /* max burst write */
diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
index b1ba37aef..7efc045 100644
--- a/include/linux/miscdevice.h
+++ b/include/linux/miscdevice.h
@@ -30,9 +30,11 @@
#define NVRAM_MINOR 144
#define SGI_MMTIMER 153
#define STORE_QUEUE_MINOR 155 /* unused */
+#define LCD_MINOR 156
#define I2O_MINOR 166
#define HWRNG_MINOR 183
#define MICROCODE_MINOR 184
+#define KEYPAD_MINOR 185
#define D7S_MINOR 193
#define VFIO_MINOR 196
#define TUN_MINOR 200
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: panel: move LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h
2016-12-15 19:43 [PATCH] misc: panel: move LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h Corentin Labbe
@ 2017-01-10 17:37 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-01-10 17:37 UTC (permalink / raw)
To: Corentin Labbe; +Cc: willy, ksenija.stanojevic, arnd, linux-kernel
On Thu, Dec 15, 2016 at 08:43:52PM +0100, Corentin Labbe wrote:
> This patch move the define for LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h.
> It's better that all minor number definitions are in the same place.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/misc/panel.c | 3 ---
> include/linux/miscdevice.h | 2 ++
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/panel.c b/drivers/misc/panel.c
> index 6030ac5..b05c3c7 100644
> --- a/drivers/misc/panel.c
> +++ b/drivers/misc/panel.c
> @@ -61,9 +61,6 @@
> #include <linux/io.h>
> #include <linux/uaccess.h>
>
> -#define LCD_MINOR 156
> -#define KEYPAD_MINOR 185
> -
> #define PANEL_VERSION "0.9.5"
>
> #define LCD_MAXBYTES 256 /* max burst write */
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index b1ba37aef..7efc045 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -30,9 +30,11 @@
> #define NVRAM_MINOR 144
> #define SGI_MMTIMER 153
> #define STORE_QUEUE_MINOR 155 /* unused */
> +#define LCD_MINOR 156
> #define I2O_MINOR 166
> #define HWRNG_MINOR 183
> #define MICROCODE_MINOR 184
> +#define KEYPAD_MINOR 185
> #define D7S_MINOR 193
> #define VFIO_MINOR 196
> #define TUN_MINOR 200
Doesn't apply to my tree :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-10 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-15 19:43 [PATCH] misc: panel: move LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h Corentin Labbe
2017-01-10 17:37 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).