From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761421AbcLPMfR (ORCPT ); Fri, 16 Dec 2016 07:35:17 -0500 Received: from foss.arm.com ([217.140.101.70]:52400 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759852AbcLPMfJ (ORCPT ); Fri, 16 Dec 2016 07:35:09 -0500 Date: Fri, 16 Dec 2016 12:35:12 +0000 From: Will Deacon To: zhong jiang Cc: catalin.marinas@arm.com, rrichter@cavium.com, mark.rutland@arm.com, arnd@arndb.de, ard.biesheuvel@linaro.org, robh+dt@kernel.org, dwoods@ezchip.com, jeremy.linton@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE Message-ID: <20161216123512.GF13191@arm.com> References: <1481725151-20549-1-git-send-email-zhongjiang@huawei.com> <1481725151-20549-3-git-send-email-zhongjiang@huawei.com> <5853AF6D.20305@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5853AF6D.20305@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 05:10:05PM +0800, zhong jiang wrote: > On 2016/12/14 22:19, zhongjiang wrote: > > From: zhong jiang > > > > when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the > > fuctions should not be use. therefore, we add the dependency. > > > > Signed-off-by: zhong jiang > > --- > > arch/arm64/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 969ef88..694ca73 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS > > > > config ARCH_WANT_HUGE_PMD_SHARE > > def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > > + depends on HUGETLB_PAGE > > > > config ARCH_HAS_CACHE_LINE_SIZE > > def_bool y > Hi, > I still think it is a issue. Perhaps above changelog is unclear. Further explain is as follows. > when hugetlb_pages is disable and arch_want_huge_pmd_share is enable, we maybe call > huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not > exported. is it right ?? The only users of ARCH_WANT_HUGE_PMD_SHARE on arm64 are: arch/arm64/mm/hugetlbpage.c: if (IS_ENABLED(CONFIG_ARCH_WANT_HUGE_PMD_SHARE) && mm/hugetlb.c:#ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE mm/hugetlb.c:#else /* !CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ mm/hugetlb.c:#endif /* CONFIG_ARCH_WANT_HUGE_PMD_SHARE */ and neither of those files are compiled if !HUGETLB_PAGE. Are you actually seeing a problem here? Will