From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761958AbcLPWQC (ORCPT ); Fri, 16 Dec 2016 17:16:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40438 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756130AbcLPWPy (ORCPT ); Fri, 16 Dec 2016 17:15:54 -0500 Date: Fri, 16 Dec 2016 16:15:50 -0600 From: Josh Poimboeuf To: Petr Mladek Cc: Jessica Yu , Jiri Kosina , Miroslav Benes , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michael Ellerman , Heiko Carstens , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Vojtech Pavlik , Jiri Slaby , Chris J Arges , Andy Lutomirski , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v3 03/15] livepatch: temporary stubs for klp_patch_pending() and klp_update_patch_state() Message-ID: <20161216221550.qp26jmhe3txpl6op@treble> References: <26bb2315093328bf31e94fdd6eec61c341a6e924.1481220077.git.jpoimboe@redhat.com> <20161216144159.GE393@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161216144159.GE393@pathway.suse.cz> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 16 Dec 2016 22:15:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 03:41:59PM +0100, Petr Mladek wrote: > On Thu 2016-12-08 12:08:28, Josh Poimboeuf wrote: > > Create temporary stubs for klp_patch_pending() and > > klp_update_patch_state() so we can add TIF_PATCH_PENDING to different > > architectures in separate patches without breaking build bisectability. > > > > Signed-off-by: Josh Poimboeuf > > --- > > include/linux/livepatch.h | 7 ++++++- > > kernel/livepatch/core.c | 3 +++ > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h > > index 9072f04..60558d8 100644 > > --- a/include/linux/livepatch.h > > +++ b/include/linux/livepatch.h > > @@ -123,10 +123,15 @@ void arch_klp_init_object_loaded(struct klp_patch *patch, > > int klp_module_coming(struct module *mod); > > void klp_module_going(struct module *mod); > > > > +static inline bool klp_patch_pending(struct task_struct *task) { return false; } > > I was curious about this. It is implemented correctly in the 13th > patch and it is never used until 13th patch. Yep, I'll move it to patch 13. > > > +void klp_update_patch_state(struct task_struct *task); > > It seems that the stub for this function is enough. > > Well, the extra function is just a cosmetic problem. If it could be > fixed, it would be great. But the patch makes sense: > > Reviewed-by: Petr Mladek > > Best Regards, > Petr > -- Josh